fix(ColorPicker): make default trigger keyboard accessible - #59130

Run & review this pull request in StackBlitz Codeflow.

👁 Visual Regression Report for PR #59130 Passed ✅

🎯 Target branch: master (549d0ee)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

sequenceDiagram
  participant 用户
  participant ColorTrigger
  participant ColorPicker
  用户->>ColorTrigger: 按下 Enter 或 Space
  ColorTrigger->>ColorTrigger: 检查禁用、重复和默认阻止状态
  ColorTrigger->>ColorPicker: 调用 onOpenChange(!open)

Merge Risk: ⚪ Minimal · up to f1d50

The hover-mode keyboard concern is resolved by the current state wiring. No actionable merge risk remains in the supplied evidence.

Security Architecture Review

Security architecture risk: 🔵 Low · up to f1d50

The change makes the default picker trigger keyboard-operable without showing a new route around its disabled state or a new sensitive action. The assessment is limited to the available component behavior and does not establish complete security coverage.

Retained concerns
No architecture-level concerns identified.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{我是兔子，轻敲 Enter，
触发器亮起，弹层开启。
再按空格，弹层收拢，
重复按键，安静停留。
清除按钮只在可清时应答，
胡萝卜旁，我蹦跳庆贺。}

_{Comment @coderabbitai help to get the list of available commands.}

Bundle Report

Changes will increase total bundle size by 740 bytes (0.02%) ⬆️. This is within the configured threshold ✅

Affected Assets, Files, and Routes:

npm i https://pkg.pr.new/antd@59130

commit: f1d502a

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (549d0ee) to head (f1d502a).

@@            Coverage Diff            @@
##            master    #59130   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          834       834           
  Lines        16048     16066   +18     
  Branches      4211      4225   +14     
=========================================
+ Hits         16048     16066   +18     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Overlap disclosure: a follow-up changed-file audit found the earlier draft #58235, which includes the same default-trigger keyboard work inside a much broader ColorPicker accessibility redesign. I should have linked it when opening this PR.

#59130 is intentionally the narrow master-targeted patch for item 1 of #57935 only: default-trigger semantics/Enter-Space activation plus removal of misleading button semantics from the inert ColorClear marker. It is currently mergeable and does not include #58235’s panel focus management, presets/slider/input redesign, locale expansion, styling, or dependency on react-component/color-picker#286. #58235 remains a conflicting draft against feature.

If maintainers prefer to land the comprehensive draft as a unit, I will close #59130. Otherwise, please evaluate this as a bounded patch that can land independently, with the remaining accessibility work staying in #58235.

AI assistance disclosure: Codex helped enumerate overlapping changed files and compare the exact PR scopes; I verified both current PR states and diffs before posting.

Addressed the hover-trigger keyboard gap at exact head 25216f866a0f32f5fb3a4b38df26364be9f62305.

The default trigger now routes Enter/Space directly through ColorPicker's controlled open-state handler instead of relying on a synthetic click, so both trigger="click" and trigger="hover" work. Added a focused hover regression covering Enter to open and Space to close.

Validation: ColorPicker Jest file 58/58 tests and 5/5 snapshots passed; focused ESLint, Prettier, and git diff --check passed.

AI assistance disclosure: Codex helped trace the rc-trigger event path and implement the focused regression; I verified the exact head and all reported commands locally.

处理下冲突

Merged current master 4a39f54842eade4e565ab336ef6097cd7e723cdd and resolved the requested conflicts at signed/GitHub-Verified head 2400bb68354d87092d984c590d0c37a1abbbfb92.

The resolution preserves upstream disabled styling and behavior for the actionable clear control. The trigger-only color marker keeps that styling but has no button role or tab stop. Its two upstream assertions were updated to match this distinction; the panel clear-control disabled test still passes.

Validation:

• 51 distinct affected test suites pass across ColorPicker, Form, ConfigProvider, Space and Watermark; one additional suite is skipped. The initial broad run passed 38 suites and exposed only two marker assertions in ColorPicker's index file. After correction, the entire index file plus Space/Watermark passed 13 suites / 206 tests / 84 snapshots. The broader run passed 577 snapshots.
• Full repository TypeScript passes after standard version generation and dumi setup.
• Focused ESLint, Biome, Prettier and diff checks pass.
• The final PR remains 16 files: ColorPicker source/tests plus its dependent snapshots. Remote changed-file blobs match the local branch, and the merge commit signature is verified.

CI follow-up: test-node stopped in dependency installation (ut), before ut test:node ran. The resolver reported no matching [email protected], required by @eslint-react/[email protected]. This PR's package.json is byte-identical to current master. The version is now returned by npm view, so this appears to be a transient resolution/publication problem, rather than a Node test failure. The local exact-head Node suite passes 1,022 tests (40 skipped). GitHub CLI did not accept my rerun request; please rerun the failed job when available.

Addressed the September 22 review at signed/GitHub-Verified head f1d502ae57022d1dd63d06d44a47b00df0bc2b46 (rebased onto current master).

• The default trigger now uses the existing localized ColorPicker text for transparent, single-color, and gradient states instead of a raw CSS value. The zh-TW regression also verifies that changing one solid RGB value to another leaves its accessible name stable.
• The trigger-only ColorClear has no role="button" or tab stop when it has no clear action; the actionable panel clear button retains keyboard operation. The regression checks the cleared trigger does not contain an interactive clear marker.
• Local exact-head validation passes 12 related suites, 713 tests, and 625 snapshots (7 tests skipped), plus TypeScript, ESLint, Biome, and diff checks. All 16 changed files match the pushed head.

#59206 is approved and also changes ColorClear.tsx to localize the actionable clear button. It should merge first; I can then rebase this PR onto it to preserve both fixes. All reported exact-head CI checks have now completed successfully or with expected skips, with no pending or failed checks, including React 18/latest, build, lint, coverage, module/dist, and visual regression. I downloaded the visual report artifact; it reports no image differences. The PR is still open with changes requested, so CI success is not maintainer acceptance.