Skip to content

fix(locale): correct Traditional Chinese picker terms - #59129

Merged
li-jia-nan merged 1 commit into
ant-design:masterfrom
nrps9909:codex/fix-zhtw-picker-terms
Aug 30, 2026
Merged

fix(locale): correct Traditional Chinese picker terms#59129
li-jia-nan merged 1 commit into
ant-design:masterfrom
nrps9909:codex/fix-zhtw-picker-terms

Conversation

@nrps9909

@nrps9909 nrps9909 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the unintended space from the zh-TW DatePicker confirmation label (確 定 → 確定)
  • use the established Taiwan UI term for gradient color (漸變色 → 漸層色)
  • add a focused locale-contract regression for both strings

Why

The DatePicker label currently renders a visible space inside a two-character action whose other Ant Design zh-TW confirmation labels consistently use 確定. 漸變色 is the Mainland/Hong Kong wording; Taiwan software interfaces use 漸層色 for gradient color.

This keeps the changes together as one zh-TW terminology correction rather than splitting individual strings into separate pull requests.

Verification

  • exact-base focused regression failed with Expected: 確定, Received: 確 定
  • fixed full locale-provider file: 77/77 tests passed
  • focused ESLint passed
  • focused Biome passed
  • focused Prettier check passed
  • git diff --check passed
  • audited current open PR titles and bodies; no zh-TW locale overlap found

AI assistance disclosure: Codex was used to audit Taiwan terminology, check open-PR overlap, add the regression, and run validation. I verified both translations, the test output, diff, and signed commit.

@bolt-new-by-stackblitz

bolt-new-by-stackblitz Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions

github-actions Bot commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Preview is ready

@github-actions

github-actions Bot commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

👁 Visual Regression Report for PR #59129 Passed ✅

🎯 Target branch: master (d58fe29)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

📖 中文报告

👁 PR #59129 视觉回归报告 通过 ✅

🎯 目标分支: master (d58fe29)

🎊 恭喜!未发现视觉回归差异。

@coderabbitai

coderabbitai Bot commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a5a42ced-1595-4e50-8ac9-a074e37847de

📥 Commits

Reviewing files that changed from the base of the PR and between d58fe29 and 6cfb837.

📒 Files selected for processing (3)
  • components/date-picker/locale/zh_TW.ts
  • components/locale/__tests__/index.test.tsx
  • components/locale/zh_TW.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Summary by CodeRabbit

  • 改进

    • 优化繁体中文（台湾）本地化文案：日期选择器确认按钮显示为「確定」。
    • 更新颜色选择器渐变色术语为「漸層色」，提升台湾地区用语准确性。

  • 测试

    • 新增本地化文案校验，确保相关显示内容符合预期。

Walkthrough

台湾语言包更新了 DatePicker 确认按钮和 ColorPicker 渐变色文案，并新增测试验证这两项文案。

Changes

台湾语言包

Layer / File(s) Summary
文案更新与测试
components/date-picker/locale/zh_TW.ts, components/locale/zh_TW.ts, components/locale/__tests__/index.test.tsx		 将 DatePicker 文案改为「確定」，将 ColorPicker 文案改为「漸層色」，并新增测试验证两项文案。

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 6cfb8

This PR makes two localized Traditional Chinese wording corrections and adds regression coverage, with the listed checks passing; no actionable merge-blocking risk remains.

Suggested reviewers: li-jia-nan

Poem

小兔挥爪改文案，
「確定」按钮不留缝。
「漸層色」轻轻落，
测试跟着点头笑。
台湾语言包更清晰。

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 标题准确概括了主要变更，即修正繁体中文选择器术语。
Description check ✅ Passed 描述与变更内容一致，说明了两处 zh-TW 文案修正、回归测试和验证结果。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from li-jia-nan August 27, 2026 12:30
@pkg-pr-new

pkg-pr-new Bot commented Aug 27, 2026

Copy link
Copy Markdown
More templates

npm i https://pkg.pr.new/antd@59129

commit: 6cfb837

@codecov

codecov Bot commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 1 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.22MB -1 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.min.js -1 bytes 1.79MB -0.0%

Files in antd-with-locales.min.js:

  • ./components/locale/zh_TW.ts → Total Size: 4.01kB

@codecov

codecov Bot commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d58fe29) to head (6cfb837).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master    #59129   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          834       834           
  Lines        15994     15994           
  Branches      4205      4205           
=========================================
  Hits         15994     15994

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 30, 2026
@li-jia-nan
li-jia-nan merged commit df3386b into ant-design:master Aug 30, 2026
44 checks passed
@aibayanyu20 aibayanyu20 mentioned this pull request Aug 31, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@li-jia-nan li-jia-nan li-jia-nan approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nrps9909 @li-jia-nan