Skip to content

Comments

test: update snap#55188

Merged
li-jia-nan merged 1 commit intonextfrom
trans-snap
Sep 29, 2025
Merged

test: update snap#55188
li-jia-nan merged 1 commit intonextfrom
trans-snap

Conversation

@li-jia-nan
Copy link
Member

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ⌨️ Accessibility improvement
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English test: update snap
🇨🇳 Chinese test: update snap

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch trans-snap

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2025

👁 Visual Regression Report for PR #55188 Passed ✅

🎯 Target branch: next (0c34a14)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2025

Preview is ready

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @li-jia-nan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating an existing snapshot test for the Transfer component. The update is necessary to align the test's expected output with recent modifications to the underlying ant-tooltip component's DOM structure, ensuring the test accurately reflects the current rendering behavior.

Highlights

  • Snapshot Test Update: The pull request updates the snapshot test for the Transfer component, specifically demo-extend.test.ts.snap.
  • DOM Structure Alignment: The changes reflect an updated DOM structure for ant-tooltip elements within the Transfer component's rendering, adjusting class names and element hierarchy.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates test snapshots for the Transfer component. The changes are consistent across all updated snapshots and reflect a structural refactoring of the internally used Tooltip component. Specifically, the tooltip's content wrapper has been simplified from .ant-tooltip-content > .ant-tooltip-inner to a single .ant-tooltip-container, and the tooltip arrow now contains a .ant-tooltip-arrow-content span. A new ant-tooltip-css-var class has also been added, likely for improved theming with CSS variables. The changes appear correct and intentional, and I have no specific feedback to add.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/antd.min.js 495.05 KB
dist/antd-with-locales.min.js 589.85 KB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 29, 2025

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@55188

commit: 2a668f3

@codecov
Copy link

codecov bot commented Sep 29, 2025

Bundle Report

Bundle size has no change ✅

@cloudflare-workers-and-pages
Copy link

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2a668f3
Status: ✅  Deploy successful!
Preview URL: https://3a26a506.ant-design.pages.dev
Branch Preview URL: https://trans-snap.ant-design.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

Deploying ant-design-next with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2a668f3
Status: ✅  Deploy successful!
Preview URL: https://2c842280.ant-design-next.pages.dev
Branch Preview URL: https://trans-snap.ant-design-next.pages.dev

View logs

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (next@0c34a14). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #55188   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?       798           
  Lines           ?     14711           
  Branches        ?      3893           
========================================
  Hits            ?     14711           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 29, 2025
@li-jia-nan li-jia-nan merged commit e19539d into next Sep 29, 2025
50 checks passed
@li-jia-nan li-jia-nan deleted the trans-snap branch September 29, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants