perf(button): rm unnecessary useMemo for mergedProps by meet-student · Pull Request #55093 · ant-design/ant-design

meet-student · 2025-09-19T13:17:07Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog! Track your changes, like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	rm unnecessary useMemo for mergedProps
🇨🇳 Chinese	rm unnecessary useMemo for mergedProps

bolt-new-by-stackblitz · 2025-09-19T13:17:11Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-09-19T13:17:15Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-09-19T13:17:15Z

gemini-code-assist · 2025-09-19T13:17:18Z

Summary of Changes

Hello @meet-student, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a performance optimization within the Button component. It streamlines the creation of mergedProps by removing a useMemo hook that was deemed unnecessary, thereby reducing potential overhead and simplifying the component's rendering process without altering its functionality.

Highlights

Performance Optimization: Removed an unnecessary useMemo hook from the Button component's mergedProps calculation, aiming to improve rendering performance.
Code Simplification: The mergedProps object is now created directly without memoization, simplifying the component's internal logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2025-09-19T13:17:18Z

👁 Visual Regression Report for PR #55093 Failed ❌

🎯 Target branch: next (390435e)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 1 changed

Expected (Branch next)	Actual (Current PR)	Diff
table-sticky.dark.png	table-sticky.dark.png

Important

There are 1 diffs found in this PR: 🔄 1 changed.
Please check all items:

Visual diff is acceptable

components/button/button.tsx

gemini-code-assist

Code Review

This pull request aims to improve performance by removing a useMemo hook. However, this change might have the opposite effect. The mergedProps object is used in the useMergeSemantic hook, which relies on stable dependencies for its internal memoization. By creating a new mergedProps object on every render, this memoization is defeated, leading to unnecessary recalculations of styles and class names. This can negatively impact performance by causing more frequent re-renders of the component. I've added a comment with a suggestion to restore the useMemo.

components/button/button.tsx

pkg-pr-new · 2025-09-19T13:21:00Z

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@55093

commit: bc04cf4

codecov · 2025-09-19T13:22:29Z

Bundle Report

Changes will decrease total bundle size by 110 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.75MB	-110 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.min.js`	-55 bytes	2.06MB	-0.0%
`antd.min.js`	-55 bytes	1.69MB	-0.0%

codecov · 2025-09-19T13:43:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (390435e) to head (bc04cf4).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #55093   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          793       793           
  Lines        14635     14634    -1     
  Branches      3889      3889           
=========================================
- Hits         14635     14634    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

li-jia-nan reviewed Sep 19, 2025

View reviewed changes

components/button/button.tsx Outdated Show resolved Hide resolved

gemini-code-assist bot reviewed Sep 19, 2025

View reviewed changes

components/button/button.tsx Outdated Show resolved Hide resolved

meet-student mentioned this pull request Sep 19, 2025

Support better customization with semantic classNames/styles #54995

Closed

63 tasks

thinkasany approved these changes Sep 19, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 19, 2025

perf: rm unnecessary useMemo for mergedProps

bc04cf4

li-jia-nan approved these changes Sep 19, 2025

View reviewed changes

li-jia-nan merged commit 2c75cd4 into ant-design:next Sep 19, 2025
39 checks passed

meet-student deleted the memo branch October 1, 2025 02:47

Uh oh!

Comments

Conversation

meet-student commented Sep 19, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Sep 19, 2025

Uh oh!

coderabbitai bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

github-actions bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Sep 19, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions bot commented Sep 19, 2025 • edited by li-jia-nan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #55093 Failed ❌

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

pkg-pr-new bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Sep 19, 2025 •

edited

Loading

github-actions bot commented Sep 19, 2025 •

edited

Loading

github-actions bot commented Sep 19, 2025 •

edited by li-jia-nan

Loading

pkg-pr-new bot commented Sep 19, 2025 •

edited

Loading

codecov bot commented Sep 19, 2025 •

edited

Loading

codecov bot commented Sep 19, 2025 •

edited

Loading