Skip to content

Comments

test: improve semantic test#55092

Merged
meet-student merged 2 commits intoant-design:nextfrom
meet-student:test-improve
Sep 19, 2025
Merged

test: improve semantic test#55092
meet-student merged 2 commits intoant-design:nextfrom
meet-student:test-improve

Conversation

@meet-student
Copy link
Member

@meet-student meet-student commented Sep 19, 2025

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ⌨️ Accessibility improvement
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

之前合并的语义化单测拆分下, 后续语义化单测写在单个文件中。现在历史有些有单个文件有些没有

📝 Change Log

Language Changelog
🇺🇸 English improve semantic test
🇨🇳 Chinese improve semantic test

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Sep 19, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 19, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025 •
edited
Loading

👁 Visual Regression Report for PR #55092 Failed ❌

🎯 Target branch: next (2c59bfc)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 2 changed

Expected (Branch next) Actual (Current PR) Diff
table-sticky.dark.png table-sticky.dark.png table-sticky.dark.png table-sticky.dark.png
table-sticky.default.png table-sticky.default.png table-sticky.default.png table-sticky.default.png

Important

There are 2 diffs found in this PR: 🔄 2 changed.
Please check all items:

  • Visual diff is acceptable

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025 •
edited
Loading

Preview is ready

accesslint[bot]
accesslint bot reviewed Sep 19, 2025
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Sep 19, 2025

Summary of Changes

Hello @meet-student, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the organization and clarity of semantic tests within the component library. It refactors existing tests related to dynamic classNames and styles by moving them into dedicated semantic.test.tsx files and standardizing the naming conventions for these test suites. This change aims to make it easier to locate, understand, and maintain tests that verify the semantic behavior of components.

Highlights

  • Test File Renaming: Renamed style-class.test.tsx files to semantic.test.tsx for Anchor and Breadcrumb components to better reflect their content.
  • Semantic Test Consolidation: Moved semantic classNames and styles tests from general index.test.tsx files into dedicated semantic.test.tsx files for Button, FloatButton, and Input components.
  • Standardized Test Descriptions: Updated the describe block names in Divider and Input semantic test files to follow the ComponentName.Semantic convention, enhancing consistency across test suites.
  • Import Adjustments: Added necessary FloatButtonProps and InputProps type imports to their respective semantic.test.tsx files after test consolidation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 19, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

感谢您的贡献！这次的PR很好地将各个组件的语义化测试重构到了独立的 semantic.test.tsx 文件中，这有助于改善测试代码的组织结构和可维护性。代码改动大部分都很好，我只发现了一个小的复制粘贴错误，已在具体的评论中指出。修改后即可合并。

@meet-student meet-student mentioned this pull request Sep 19, 2025
Closed
63 tasks
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 19, 2025 •
edited
Loading

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@55092

commit: 18a93b4

meet-student and others added 2 commits September 19, 2025 21:06
@meet-student
improve semantic test
4bb52d1
@meet-student @gemini-code-assist
Update components/button/__tests__/semantic.test.tsx
18a93b4 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: 遇见同学 <[email protected]>
@codecov
Copy link

codecov bot commented Sep 19, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 7.91MB (211.09%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
antd.min-array-push 11.66MB 7.91MB (211.09%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.js (New) 6.13MB 6.13MB 100.0% 🚀
antd.js (New) 5.53MB 5.53MB 100.0% 🚀
antd-with-locales.min.js (Deleted) -2.06MB 0 bytes -100.0% 🗑️
antd.min.js (Deleted) -1.69MB 0 bytes -100.0% 🗑️

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 19, 2025
@codecov
Copy link

codecov bot commented Sep 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2c59bfc) to head (18a93b4).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #55092   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          793       793           
  Lines        14635     14635           
  Branches      3889      3889           
=========================================
  Hits         14635     14635

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meet-student meet-student merged commit 390435e into ant-design:next Sep 19, 2025
38 of 39 checks passed
@meet-student meet-student deleted the test-improve branch October 1, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thinkasany thinkasany thinkasany approved these changes

+2 more reviewers

@accesslint accesslint[bot] accesslint[bot] left review comments

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@meet-student @thinkasany