feat(Modal): Support better customization with semantic classNames & styles#55081
feat(Modal): Support better customization with semantic classNames & styles#55081thinkasany merged 33 commits intonextfrom
Conversation
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
👁 Visual Regression Report for PR #55081 Failed ❌
Important There are 7 diffs found in this PR: 🔄
|
|
|
Summary of ChangesHello @li-jia-nan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the customization capabilities of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a great enhancement for Modal customization by allowing classNames and styles to be provided as functions of the component's props. This provides a powerful way to apply dynamic styles. The changes in interface.ts and ConfirmDialog.tsx correctly propagate the new types and props. However, I've found an issue in Modal.tsx where the mergedProps object passed to these functions does not correctly include all default prop values, which could lead to bugs in consumer code. My detailed comment addresses this with a suggested fix.
size-limit report 📦
|
More templates
commit: |
Bundle ReportChanges will decrease total bundle size by 7.9MB (-67.79%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
Deploying ant-design-next with
|
| Latest commit: |
afd334c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ec00b142.ant-design-next.pages.dev |
| Branch Preview URL: | https://semantic-modal.ant-design-next.pages.dev |
Deploying ant-design with
|
| Latest commit: |
6816f59
|
| Status: | 🚫 Build failed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #55081 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 798 798
Lines 14727 14728 +1
Branches 3896 3896
=========================================
+ Hits 14727 14728 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
li-jia-nan
changed the title
|
4 participants
…styles
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log