feat(result): Support better customization with semantic classNames/styles as function by ccc1018 · Pull Request #55044 · ant-design/ant-design

ccc1018 · 2025-09-17T02:26:39Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog! Track your changes, like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	Support better customization with semantic classNames/styles
🇨🇳 Chinese	Support better customization with semantic classNames/styles

…feature/result

…ture/result" This reverts commit a64cb1b, reversing changes made to 2343dd9.

This reverts commit 7d3a4de.

This reverts commit cfe65dd.

Signed-off-by: thinkasany <[email protected]>

…result

…nges

bolt-new-by-stackblitz · 2025-09-17T02:26:42Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-09-17T02:26:46Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

Public repositories are always opted into early access features.
You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-09-17T02:26:49Z

👁 Visual Regression Report for PR #55044 Failed ❌

🎯 Target branch: next (38fc1dc)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🆕 3 added

Expected (Branch next)	Actual (Current PR)	Diff
	result-style-class.compact.png	🆕🆕🆕 Added 🆕🆕🆕
	result-style-class.dark.png	🆕🆕🆕 Added 🆕🆕🆕
	result-style-class.default.png	🆕🆕🆕 Added 🆕🆕🆕

Important

There are 3 diffs found in this PR: 🆕 3 added.
Please check all items:

Visual diff is acceptable

github-actions · 2025-09-17T02:26:51Z

components/result/index.en-US.md

components/result/index.tsx

components/result/index.zh-CN.md

…eature/result

ccc1018 · 2025-09-28T01:24:13Z

@thinkasany 麻烦大佬帮我看看这个，pr有没有问题

Copilot

Pull Request Overview

This PR enhances the Result component to support better customization through semantic classNames and styles that can accept either objects or functions. This allows for more dynamic styling based on component props.

Enhanced the classNames and styles props to accept functions in addition to objects
Added proper TypeScript types for function-based styling
Created comprehensive demo and test coverage for the new functionality

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
components/result/index.tsx	Added type imports and updated props types to support function-based classNames/styles
components/result/index.en-US.md	Updated API documentation to describe the new function-based styling capabilities
components/result/index.zh-CN.md	Updated Chinese API documentation for the new styling functionality
components/result/demo/style-class.tsx	Added comprehensive demo showcasing both object and function-based styling
components/result/demo/style-class.md	Added demo documentation explaining the new styling features
components/result/tests/index.test.tsx	Enhanced tests with proper types and added function-based styling test coverage
components/result/tests/snapshots/demo.test.ts.snap	Updated snapshots for the new demo
components/result/tests/snapshots/demo-extend.test.ts.snap	Updated extended snapshots for the new demo

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

thinkasany · 2025-09-28T02:08:51Z

@thinkasany 麻烦大佬帮我看看这个，pr有没有问题

都通过啦，我看起来没啥问题，等其他同学再看看~

感谢你的贡献~

ccc1018 · 2025-09-28T02:11:17Z

@thinkasany 麻烦大佬帮我看看这个，pr有没有问题

都通过啦，我看起来没啥问题，等其他同学再看看~

感谢你的贡献~

好的好的，麻烦了

Signed-off-by: lijianan <[email protected]>

thinkasany · 2025-09-30T05:44:06Z

components/result/demo/style-class.tsx

+};
+
+const stylesObject: ResultProps['styles'] = {
+  root: { borderWidth: 2, borderStyle: 'dashed', padding: 16 },


@meet-student 调色师过来调一下 🎨

components/result/index.zh-CN.md

Signed-off-by: thinkasany <[email protected]>

github-actions · 2025-09-30T06:16:40Z

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。

ccc1018 and others added 26 commits September 15, 2025 18:06

merge branch 'next' of github.com:ant-design/ant-design into next

d179397

Support better customization with semantic classNames/styles

dce3c28

Support better customization with semantic classNames/styles

cfe65dd

Merge branch 'next' into next

bd6ce2a

Support better customization with semantic classNames/styles

cfcf056

Merge branch 'next' into next

ff6b624

Support better customization with semantic classNames/styles

7d3a4de

Merge branch 'next' of https://github.com/ant-design/ant-design into …

2343dd9

…feature/result

Merge branch 'next' of github.com:ccc1018/ant-design into feature/result

a64cb1b

Revert "Merge branch 'next' of github.com:ccc1018/ant-design into fea…

6bfcb69

…ture/result" This reverts commit a64cb1b, reversing changes made to 2343dd9.

Revert "Support better customization with semantic classNames/styles"

c5d3853

This reverts commit 7d3a4de.

Revert "Support better customization with semantic classNames/styles"

45ed533

This reverts commit cfe65dd.

Support better customization with semantic classNames/styles

e4064bb

Support better customization with semantic classNames/styles

465616e

Update components/alert/Alert.tsx

80fcdc4

Signed-off-by: thinkasany <[email protected]>

Merge branch 'ant-design:next' into next

138e479

Merge branch 'next' of https://github.com/ant-design/ant-design into …

9a9fba8

…result

Support better customization with semantic classNames/styles

2665ba1

Support better customization with semantic classNames/styles

95d6c45

Support better customization with semantic classNames/styles

af10dda

Merge branch 'next' of github.com:ccc1018/ant-design into next

4d3eac3

Support better customization with semantic classNames/styles

9fe1b6e

Merge branch 'next' of github.com:ccc1018/ant-design into feature/result

fc07ec7

fix: remove alert component changes from result branch

7e8af9f

fix: reset alert component to next branch state, keep only result cha…

54c193b

…nges

Support better customization with semantic classNames/styles

83b60cb

meet-student reviewed Sep 22, 2025

View reviewed changes

components/result/index.en-US.md Outdated Show resolved Hide resolved

meet-student reviewed Sep 22, 2025

View reviewed changes

components/result/index.tsx Outdated Show resolved Hide resolved

meet-student reviewed Sep 22, 2025

View reviewed changes

components/result/index.zh-CN.md Outdated Show resolved Hide resolved

Merge branch 'next' into feature/result

0c1b1a4

meet-student mentioned this pull request Sep 22, 2025

Support better customization with semantic classNames/styles #54995

Closed

63 tasks

ccc1018 and others added 6 commits September 23, 2025 20:35

Fix modify in the file

06fd877

Merge branch 'next' into feature/result

cf2c134

format doc table

8dbe99f

Merge branch 'next' into feature/result

089eff6

fix .snap

eea85c3

Merge branch 'feature/result' of github.com:ccc1018/ant-design into f…

34e9784

…eature/result

thinkasany requested a review from Copilot September 28, 2025 02:05

Copilot AI reviewed Sep 28, 2025

View reviewed changes

li-jia-nan and others added 6 commits September 29, 2025 01:46

Refactor Result component to use props directly

b9d5e5c

Signed-off-by: lijianan <[email protected]>

Fix formatting in result component props destructuring

0960fd8

Signed-off-by: lijianan <[email protected]>

Merge branch 'next' into feature/result

91ec1d4

Merge branch 'next' into feature/result

c7a5ea4

Merge branch 'next' into feature/result

e8603ff

Merge branch 'next' into feature/result

6081586

thinkasany reviewed Sep 30, 2025

View reviewed changes

components/result/index.zh-CN.md Outdated Show resolved Hide resolved

Update components/result/index.zh-CN.md

d932cab

Signed-off-by: thinkasany <[email protected]>

thinkasany approved these changes Sep 30, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 30, 2025

thinkasany merged commit 446c4a6 into ant-design:next Sep 30, 2025
38 of 39 checks passed

zombieJ mentioned this pull request Nov 4, 2025

docs: changelog of 6.0.0-alpha.4 #55604

Merged

17 tasks

Uh oh!

Comments

Conversation

ccc1018 commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Sep 17, 2025

Uh oh!

coderabbitai bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

github-actions bot commented Sep 17, 2025 • edited by thinkasany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #55044 Failed ❌

Uh oh!

github-actions bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ccc1018 commented Sep 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

thinkasany commented Sep 28, 2025

Uh oh!

ccc1018 commented Sep 28, 2025

Uh oh!

thinkasany Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ccc1018 commented Sep 17, 2025 •

edited

Loading

coderabbitai bot commented Sep 17, 2025 •

edited

Loading

github-actions bot commented Sep 17, 2025 •

edited by thinkasany

Loading

github-actions bot commented Sep 17, 2025 •

edited

Loading