feat(masonry): Support better customization with semantic classNames/styles as function by meet-student · Pull Request #55032 · ant-design/ant-design

meet-student · 2025-09-15T15:41:13Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog! Track your changes, like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	Support better customization with semantic classNames/styles as function
🇨🇳 Chinese	Support better customization with semantic classNames/styles as function

bolt-new-by-stackblitz · 2025-09-15T15:41:17Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-09-15T15:41:21Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-09-15T15:41:23Z

github-actions · 2025-09-15T15:41:24Z

👁 Visual Regression Report for PR #55032 Failed ❌

🎯 Target branch: next (25f7a0e)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 2 changed

Expected (Branch next)	Actual (Current PR)	Diff
table-sticky.dark.png	table-sticky.dark.png
table-sticky.default.png	table-sticky.default.png

Important

There are 2 diffs found in this PR: 🔄 2 changed.
Please check all items:

Visual diff is acceptable

gemini-code-assist

Summary of Changes

Hello @meet-student, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the Masonry component, enabling developers to achieve more granular and dynamic control over its appearance. By allowing classNames and styles to be defined as functions, the component can now adapt its styling based on its internal state or props, leading to highly customizable and responsive layouts. This change improves the overall flexibility and developer experience when working with the Masonry component.

Highlights

Enhanced Customization: The Masonry component now supports more flexible customization of its semantic DOM elements (root and item) through the classNames and styles props.
Function Support for Styling: The classNames and styles props can now accept functions in addition to objects, allowing for dynamic styling based on the component's current props.
New useMergeSemantic Hook: A new utility hook, useMergeSemantic, has been integrated to handle the merging of context-based and prop-based semantic class names and styles, including support for function evaluation.
Comprehensive Testing and Demos: New test cases have been added to validate the object and function forms of classNames and styles, and a new demo (style-class.tsx) with corresponding documentation has been introduced to showcase these features.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a great enhancement to the Masonry component by allowing classNames and styles to be provided as functions, enabling more dynamic and props-based customization. The implementation is solid, leveraging a new useMergeSemantic hook, and is accompanied by good tests and a clear demo. I've identified a couple of minor issues: a leftover console.log in the new demo and a broken API table in the Chinese documentation. Once these are addressed, this PR will be in excellent shape.

components/masonry/demo/style-class.tsx

components/masonry/index.zh-CN.md

codecov · 2025-09-15T15:45:04Z

Bundle Report

Changes will increase total bundle size by 90 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.76MB	90 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.min.js`	45 bytes	2.07MB	0.0%
`antd.min.js`	45 bytes	1.69MB	0.0%

pkg-pr-new · 2025-09-15T15:45:12Z

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@55032

commit: dc42c4d

codecov · 2025-09-15T16:19:04Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4782d42) to head (dc42c4d).
⚠️ Report is 4 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #55032   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          793       793           
  Lines        14621     14624    +3     
  Branches      3889      3887    -2     
=========================================
+ Hits         14621     14624    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zombieJ · 2025-09-16T07:54:43Z

components/masonry/demo/style-class.tsx

@@ -0,0 +1,97 @@
+import React from 'react';


感觉有点怪，是 BUG 还是定制样式的问题？超出了边界。

数值计算看着是对的, 定制样式边框 + 阴影看起来有点奇怪。我调整高了点

…styles as function

gemini-code-assist bot reviewed Sep 15, 2025

View reviewed changes

components/masonry/demo/style-class.tsx Outdated Show resolved Hide resolved

components/masonry/index.zh-CN.md Show resolved Hide resolved

meet-student mentioned this pull request Sep 15, 2025

Support better customization with semantic classNames/styles #54995

Closed

63 tasks

zombieJ reviewed Sep 16, 2025

View reviewed changes

feat(masonry): Support better customization with semantic classNames/…

dc42c4d

…styles as function

zombieJ approved these changes Sep 16, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 16, 2025

zombieJ merged commit e179375 into ant-design:next Sep 16, 2025
39 checks passed

meet-student deleted the masonry branch October 1, 2025 02:47

zombieJ mentioned this pull request Nov 4, 2025

docs: changelog of 6.0.0-alpha.4 #55604

Merged

17 tasks

Uh oh!

Comments

Conversation

meet-student commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Sep 15, 2025

Uh oh!

coderabbitai bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

github-actions bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 15, 2025 • edited by zombieJ Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #55032 Failed ❌

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

pkg-pr-new bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zombieJ Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

meet-student Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

meet-student commented Sep 15, 2025 •

edited

Loading

coderabbitai bot commented Sep 15, 2025 •

edited

Loading

github-actions bot commented Sep 15, 2025 •

edited

Loading

github-actions bot commented Sep 15, 2025 •

edited by zombieJ

Loading

codecov bot commented Sep 15, 2025 •

edited

Loading

pkg-pr-new bot commented Sep 15, 2025 •

edited

Loading

codecov bot commented Sep 15, 2025 •

edited

Loading

meet-student Sep 16, 2025 •

edited

Loading