Skip to content

Comments

feat(notification): Support better customization with semantic classNames/styles as function#55021

Merged
meet-student merged 56 commits intoant-design:nextfrom
GinWU05:notification
Sep 30, 2025
Merged

feat(notification): Support better customization with semantic classNames/styles as function#55021
meet-student merged 56 commits intoant-design:nextfrom
GinWU05:notification

Conversation

@GinWU05
Copy link
Contributor

@GinWU05 GinWU05 commented Sep 14, 2025

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ⌨️ Accessibility improvement
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English Support better customization with semantic classNames/styles as function
🇨🇳 Chinese Support better customization with semantic classNames/styles as function

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 14, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2025

👁 Visual Regression Report for PR #55021 Failed ❌

🎯 Target branch: next (eb80710)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🛑 9 removed, 🆕 3 added

Expected (Branch next) Actual (Current PR) Diff
drawer-style-class.compact.png drawer-style-class.compact.png ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
drawer-style-class.dark.png drawer-style-class.dark.png ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
drawer-style-class.default.png drawer-style-class.default.png ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
modal-style-class.compact.png modal-style-class.compact.png ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
modal-style-class.dark.png modal-style-class.dark.png ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
modal-style-class.default.png modal-style-class.default.png ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
result-style-class.compact.png result-style-class.compact.png ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
result-style-class.dark.png result-style-class.dark.png ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨

Warning

There are more diffs not shown in the table. Please check the Full Report for details.


Important

There are 12 diffs found in this PR: 🛑 9 removed, 🆕 3 added.
Please check all items:

  • Checked all diffs in the full report
  • Visual diff is acceptable

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2025

Preview is ready

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @GinWU05, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Ant Design notification component by introducing flexible and powerful customization options for its classNames and styles. Developers can now define these properties as static objects or dynamic functions, enabling fine-grained control over the styling of various semantic parts of a notification. This change improves the component's adaptability to diverse design requirements and provides a more robust styling API.

Highlights

  • Enhanced Notification Customization: The notification component now supports more granular customization of its classNames and styles properties. These can be provided as either static objects or dynamic functions, allowing precise control over the appearance of individual semantic elements like the root container, title, description, actions, and icon.
  • Refactored Semantic Merging Logic: The useMergeSemantic hook has been refactored. Its core merging logic is now exposed as standalone mergeSemanticClassNames and mergeSemanticStyles functions, and a non-hook mergeSemantic function. The useMergeSemantic hook now wraps this non-hook version with React.useMemo for optimized performance.
  • Updated Component Implementation: The PurePanel.tsx and useNotification.tsx files have been updated to leverage the new mergeSemantic functionality, ensuring that classNames and styles are correctly applied and merged from various sources, including component props and ConfigProvider settings.
  • Comprehensive Test Coverage: A new test file (semantic.test.tsx) has been added, including extensive test cases to validate the new customization features. These tests cover object-based and function-based classNames/styles, integration with ConfigProvider, merging priority, and graceful handling of empty inputs.
  • Documentation and Demo Updates: The documentation for the notification component (index.en-US.md, index.zh-CN.md) has been updated to reflect the new classNames and styles props. A new demo (style-class.tsx, style-class.md) has also been added to showcase practical usage of these customization options.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable feature for customizing notifications by allowing classNames and styles to be provided as functions. The refactoring of useMergeSemantic into pure functions and a corresponding hook is a solid architectural improvement. I've identified a few areas for improvement concerning performance and code redundancy within the new utility hooks. Specifically, there's some redundant logic in useMergeSemantic, and the dependency arrays in useSemanticClassNames and useSemanticStyles could be optimized to ensure memoization is effective. The new tests are comprehensive and well-written, providing good coverage for the new functionality.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 15, 2025

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@55021

commit: 79e30d4

@codecov
Copy link

codecov bot commented Sep 15, 2025

Bundle Report

Changes will increase total bundle size by 1.27kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 11.66MB 1.27kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.js 635 bytes 6.13MB 0.01%
antd.js 635 bytes 5.52MB 0.01%

@thinkasany
Copy link
Member

@meet-student 同步完记得 ap ci 执行
image

@thinkasany thinkasany requested a review from Copilot September 30, 2025 05:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 30, 2025
@meet-student meet-student merged commit 2bb5d83 into ant-design:next Sep 30, 2025
38 of 39 checks passed
@github-actions
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

钉钉社区群二维码

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants