feat(splitter): Support better customization with semantic classNames/styles as function#55013
feat(splitter): Support better customization with semantic classNames/styles as function#55013zombieJ merged 17 commits intoant-design:nextfrom
Conversation
…/styles as function
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
👁 Visual Regression Report for PR #55013 Failed ❌
Important There are 6 diffs found in this PR: 🔄
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @hcjlxl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the Splitter component by introducing the ability to define classNames and styles as functions. This change empowers developers to implement highly dynamic and context-aware styling, where visual properties can adapt directly to the component's state and props. The update improves the component's flexibility and customization options, making it more versatile for various UI requirements.
Highlights
- Dynamic Styling with Functions: The
Splittercomponent'sclassNamesandstylesprops now accept functions, enabling dynamic and conditional styling based on the component's current properties. - Prop-Based Customization: These functions receive the component's
propsas an argument, allowing for highly flexible customization that reacts to changes in orientation, theme, or other component states. - New Demo and Documentation: A new demo (
style-class.tsx) and corresponding documentation have been added to showcase the usage and benefits of this enhanced customization feature, including complex dragger styling and theme support. - Type Definition Updates: The TypeScript interface for
SplitterPropshas been updated to reflect the new function types forclassNamesandstyles, ensuring type safety and improved developer experience.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable enhancement to the Splitter component by allowing classNames and styles to be provided as functions. This enables dynamic styling based on the component's props, which is a great feature for customization. The implementation is solid, with good test coverage and a clear demonstration. I have one suggestion to simplify the TypeScript types for better maintainability. Overall, great work!
More templates
commit: |
Bundle ReportChanges will increase total bundle size by 80 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #55013 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 793 793
Lines 14642 14643 +1
Branches 3891 3891
=========================================
+ Hits 14642 14643 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
标题更新下， 截断了。 |
li-jia-nan
changed the title
Co-authored-by: lijianan <[email protected]> Signed-off-by: 遇见同学 <[email protected]>
Signed-off-by: 遇见同学 <[email protected]>
Signed-off-by: 遇见同学 <[email protected]>
|
| @@ -0,0 +1,75 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
- Demo 留 2 个水平的
- 一个为 classNames object: 添加背景色（第四个 Demo）
2. 一个为 stylesObject，修改 dragger 样式（最好在网上找找，寻一个酷炫的 dragger）
* 参考上面的 Demo 使用大居中标题，避免小文子看起来像是调试 demo：
|
🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR). 🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。 
|
5 participants
…/styles as function
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log