feat(tree): Support better customization with semantic classNames/styles as function by meet-student · Pull Request #54988 · ant-design/ant-design

meet-student · 2025-09-12T11:59:42Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog! Track your changes, like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	Support better customization with semantic classNames/styles as function
🇨🇳 Chinese	Support better customization with semantic classNames/styles as function

bolt-new-by-stackblitz · 2025-09-12T11:59:45Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-09-12T11:59:50Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

Public repositories are always opted into early access features.
You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Summary of Changes

Hello @meet-student, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the Tree component's styling flexibility by allowing developers to define classNames and styles dynamically using functions that receive component props. This change enables more adaptive and context-aware visual presentations for tree elements, making the component more versatile for various application needs.

Highlights

Enhanced Customization for Tree Component: The Tree component now supports more flexible customization of its semantic DOM elements. The classNames and styles props can now accept functions, allowing dynamic styling based on the component's current props (e.g., disabled, showIcon).
Updated TreeProps Definition: The TreeProps interface has been refactored to incorporate BaseTreeProps, enabling the new function-based classNames and styles types. This change allows for more powerful and contextual styling.
Dynamic Styling Logic: The useMergeSemantic hook within the Tree component now passes the mergedProps (including disabled state) to the classNames and styles functions, facilitating conditional styling based on the component's state.
New Demo and Documentation: A new demo (style-class.tsx) has been added to showcase both static and function-based classNames and styles usage. The API documentation (English and Chinese) has been updated to reflect these new customization capabilities.
Comprehensive Test Coverage: New test cases have been introduced to verify the correct application of both static and function-based classNames and styles, ensuring the robustness of the new customization features.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a valuable enhancement to the Tree component, allowing classNames and styles to be provided as functions for more dynamic customization. The implementation is solid, and the new functionality is well-documented and demonstrated. I've provided a few suggestions to improve test coverage, code clarity, and documentation accuracy. Overall, great work on this feature!

components/tree/Tree.tsx

components/tree/__tests__/index.test.tsx

components/tree/demo/style-class.md

components/tree/demo/style-class.tsx

github-actions · 2025-09-12T12:03:26Z

github-actions · 2025-09-12T12:05:46Z

👁 Visual Regression Report for PR #54988 Failed ❌

🎯 Target branch: next (8d2e5c4)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 1 changed, 🆕 3 added

Expected (Branch next)	Actual (Current PR)	Diff
table-sticky.default.png	table-sticky.default.png
	tree-style-class.compact.png	🆕🆕🆕 Added 🆕🆕🆕
	tree-style-class.dark.png	🆕🆕🆕 Added 🆕🆕🆕
	tree-style-class.default.png	🆕🆕🆕 Added 🆕🆕🆕

Important

There are 4 diffs found in this PR: 🔄 1 changed, 🆕 3 added.
Please check all items:

Visual diff is acceptable

pkg-pr-new · 2025-09-12T12:07:20Z

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@54988

commit: 0c198c7

codecov · 2025-09-12T12:12:30Z

Bundle Report

Changes will decrease total bundle size by 7.91MB (-67.79%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.76MB	-7.91MB (-67.79%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.min.js` (New)	2.07MB	2.07MB	100.0% 🚀
`antd.min.js` (New)	1.69MB	1.69MB	100.0% 🚀
~~`antd-with-locales.js`~~ (Deleted)	-6.14MB	0 bytes	-100.0% 🗑️
~~`antd.js`~~ (Deleted)	-5.53MB	0 bytes	-100.0% 🗑️

codecov · 2025-09-12T12:18:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8d2e5c4) to head (0c198c7).
⚠️ Report is 3 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #54988   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          798       798           
  Lines        14747     14748    +1     
  Branches      3897      3897           
=========================================
+ Hits         14747     14748    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

components/tree/Tree.tsx

Copilot

Pull Request Overview

This PR adds support for better customization of the Tree component by allowing classNames and styles props to be either objects or functions. When used as functions, they receive component props as parameters, enabling dynamic styling based on the tree's state.

Enhanced the Tree component to support function-based classNames and styles for dynamic customization
Added comprehensive test coverage for both static and function-based semantic styling
Created documentation and demo showing the new functionality

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
components/tree/Tree.tsx	Core implementation adding function support for classNames/styles with proper typing
components/tree/demo/style-class.tsx	Demo showcasing both object and function-based styling approaches
components/tree/demo/style-class.md	Documentation for the new styling feature
components/tree/index.en-US.md	English API documentation updates
components/tree/index.zh-CN.md	Chinese API documentation updates
components/tree/tests/index.test.tsx	Test coverage for semantic DOM styling functionality
components/tree/tests/snapshots/*	Updated test snapshots for the new demo

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

components/tree/demo/style-class.tsx

…les as function

components/tree/Tree.tsx

meet-student · 2025-09-30T13:10:05Z

gemini-code-assist bot reviewed Sep 12, 2025

View reviewed changes

meet-student mentioned this pull request Sep 13, 2025

Support better customization with semantic classNames/styles #54995

Closed

63 tasks

li-jia-nan reviewed Sep 17, 2025

View reviewed changes

components/tree/Tree.tsx Outdated Show resolved Hide resolved

thinkasany requested a review from Copilot September 27, 2025 12:14

Copilot AI reviewed Sep 27, 2025

View reviewed changes

components/tree/demo/style-class.tsx Show resolved Hide resolved

components/tree/demo/style-class.tsx Show resolved Hide resolved

meet-student added 3 commits September 29, 2025 21:12

feat(tree): Support better customization with semantic classNames/sty…

2b7b39f

…les as function

update demo and snap

945a9cf

chore: update demo

1bd564d

thinkasany reviewed Sep 29, 2025

View reviewed changes

components/tree/Tree.tsx Show resolved Hide resolved

li-jia-nan and others added 3 commits September 30, 2025 02:10

Merge branch 'next' into tree

a9cd2f3

Merge branch 'next' into tree

2370625

Merge branch 'next' into tree

5ba54e8

Merge branch 'next' into tree

0c198c7

zombieJ approved these changes Sep 30, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 30, 2025

thinkasany approved these changes Sep 30, 2025

View reviewed changes

thinkasany merged commit 77e7238 into ant-design:next Sep 30, 2025
37 of 39 checks passed

meet-student deleted the tree branch October 1, 2025 02:47

zombieJ mentioned this pull request Nov 4, 2025

docs: changelog of 6.0.0-alpha.4 #55604

Merged

17 tasks

Uh oh!

Comments

Conversation

meet-student commented Sep 12, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Sep 12, 2025

Uh oh!

coderabbitai bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #54988 Failed ❌

Uh oh!

pkg-pr-new bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

meet-student commented Sep 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Sep 12, 2025 •

edited

Loading

github-actions bot commented Sep 12, 2025 •

edited

Loading

github-actions bot commented Sep 12, 2025 •

edited

Loading

pkg-pr-new bot commented Sep 12, 2025 •

edited

Loading

codecov bot commented Sep 12, 2025 •

edited

Loading

codecov bot commented Sep 12, 2025 •

edited

Loading