feat(Popover/Tooltip/Popconfirm): Support better customization with semantic classNames/styles as function#54986
feat(Popover/Tooltip/Popconfirm): Support better customization with semantic classNames/styles as function#54986zombieJ merged 27 commits intoant-design:nextfrom meet-student:tooltip
Conversation
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @meet-student, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly improves the customization capabilities of the Tooltip component by introducing new props that allow developers to apply classes and styles directly to its semantic DOM elements. This change provides greater flexibility for styling tooltips, including the ability to dynamically adjust their appearance based on their current state or properties, without relying solely on global CSS overrides.
Highlights
- Enhanced Tooltip Customization: Introduced new
classNamesandstylesprops to theTooltipcomponent, allowing for more granular and semantic control over its internal DOM structure's styling. - Dynamic Styling with Functions: The new
classNamesandstylesprops can now accept functions, enabling dynamic application of classes and styles based on the tooltip's current properties (e.g.,color,placement). - New Demo and Documentation: Added a new demo (
style-class.tsx) and corresponding documentation (style-class.md,index.en-US.md,index.zh-CN.md) to illustrate how to effectively use the new customization options.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable enhancement to the Tooltip component by allowing classNames and styles to be provided as functions for dynamic styling. The implementation is well-structured, including new tests and documentation. I've identified a potential performance and type-correctness issue in the usage of the useMergeSemantic hook and provided a suggestion to resolve it.
|
|
👁 Visual Regression Report for PR #54986 Failed ❌
Warning There are more diffs not shown in the table. Please check the Full Report for details. Important There are 10 diffs found in this PR: 🔄
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #54986 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 798 798
Lines 14749 14758 +9
Branches 3896 3901 +5
=========================================
+ Hits 14749 14758 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Popover、Tooltip、Popconfirm 这三个组件需要一起做，不然 CI 过不了 |
|
统一在这个 PR 里面做吧 |
li-jia-nan
changed the title
More templates
commit: |
Bundle ReportChanges will increase total bundle size by 7.91MB (210.58%) ⬆️
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
|
…styles as function
Co-authored-by: lijianan <[email protected]>
Signed-off-by: lijianan <[email protected]>
Signed-off-by: lijianan <[email protected]>
|
lint 挂了 |
4 participants
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log