feat(upload): Support better customization with semantic classNames/styles as function#54968
feat(upload): Support better customization with semantic classNames/styles as function#54968zombieJ merged 4 commits intoant-design:nextfrom meet-student:upload
Conversation
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @meet-student, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the Upload component's styling flexibility by introducing new classNames and styles props. These props now accept functions, allowing for dynamic application of styles and classes based on component state. This change provides developers with more granular control over the component's appearance, making it easier to integrate into diverse design systems.
Highlights
- Enhanced Customization for Upload Component: The
Uploadcomponent now supportsclassNamesandstylesprops that can accept both object and function values, providing greater flexibility for dynamic styling based on component state. - Intelligent Style Merging: Integration of the
useMergeSemantichook ensures thatclassNamesandstylesprovided via component props are intelligently merged with those from theConfigProvidercontext, allowing for layered customization. - Comprehensive Test Coverage: Extensive unit tests have been added to validate the new
classNamesandstylesfunctionalities, including tests for object values, function values, and the merging behavior from context. - Updated Documentation and Demos: New demo examples and updated API documentation (in both English and Chinese) have been included to clearly illustrate how to utilize these new semantic styling capabilities for the
Uploadcomponent.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request enhances the Upload component by allowing classNames and styles props to be functions, enabling more dynamic customization. The implementation is solid, using the useMergeSemantic hook to cleanly handle the new logic. The feature is well-supported by new tests and updated documentation. I have one minor suggestion to improve code clarity.
|
|
👁 Visual Regression Report for PR #54968 Failed ❌
Important There are 6 diffs found in this PR: 🔄
|
More templates
commit: |
Bundle ReportChanges will increase total bundle size by 132 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #54968 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 798 798
Lines 14711 14713 +2
Branches 3893 3893
=========================================
+ Hits 14711 14713 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Upload component by supporting functional classNames and styles props that enable better customization of semantic DOM structures. The feature allows developers to pass functions that receive component props as parameters, providing dynamic styling capabilities.
Key changes:
- Enhanced interface definitions to support function-based semantic customization
- Integrated
useMergeSemantichook for proper handling of functional class names and styles - Added comprehensive test coverage and documentation with demo examples
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| components/upload/interface.ts | Added type definitions for functional classNames/styles support |
| components/upload/Upload.tsx | Integrated useMergeSemantic hook and updated component logic |
| components/upload/demo/style-class.tsx | New demo showcasing functional styling capabilities |
| components/upload/demo/style-class.md | Documentation for the new demo |
| components/upload/index.zh-CN.md | Updated Chinese documentation with new API descriptions |
| components/upload/index.en-US.md | Updated English documentation with new API descriptions |
| components/upload/tests/upload.test.tsx | Added comprehensive test coverage for the new functionality |
| components/upload/tests/snapshots/* | Updated test snapshots to reflect new functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: lijianan <[email protected]>
4 participants
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log