feat(transfer): Support better customization with semantic classNames/styles as function#54966
feat(transfer): Support better customization with semantic classNames/styles as function#54966zombieJ merged 3 commits intoant-design:nextfrom meet-student:transfer
Conversation
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @meet-student, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the customization options for the Transfer component by allowing developers to provide classNames and styles as functions. This change enables more flexible and conditional styling, adapting the component's appearance based on its current state or props, thereby offering greater control over its visual presentation without altering its core logic.
Highlights
- Enhanced Customization for Transfer Component: The Transfer component now supports classNames and styles props that can accept functions, allowing for dynamic application of CSS classes and inline styles based on component properties.
- Improved Type Definitions: New TypeScript types (TransferClassNamesType, TransferStylesType) have been introduced to accurately reflect the expanded functionality of classNames and styles props.
- Updated Semantic Merging Logic: The internal useMergeSemantic hook has been updated to correctly process and apply class names and styles when provided as functions, passing the component's current props for conditional logic.
- Comprehensive Test Coverage: New test cases have been added to ensure the correct application of both object-based and function-based classNames and styles for the Transfer component.
- New Demo and Documentation: A new demo (style-class.tsx) and corresponding documentation (style-class.md, index.en-US.md, index.zh-CN.md) have been added to illustrate and explain the new customization capabilities.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
👁 Visual Regression Report for PR #54966 Failed ❌
Important There are 3 diffs found in this PR: 🆕
|
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable enhancement to the Transfer component by allowing classNames and styles to be passed as functions, enabling more dynamic and conditional styling. The implementation is well-executed, leveraging existing hooks and patterns within the antd ecosystem. The changes are accompanied by thorough tests and a clear demonstration, which is excellent. I have a couple of minor suggestions to improve code conciseness in the tests and the new demo file.
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #54966 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 796 796
Lines 14673 14674 +1
Branches 3890 3890
=========================================
+ Hits 14673 14674 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
More templates
commit: |
Bundle ReportChanges will increase total bundle size by 334 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Transfer component to support better customization by allowing classNames and styles props to be passed as functions in addition to objects. This enables dynamic styling based on component props.
Key changes include:
- Updated type definitions to support both object and function forms for semantic styling
- Modified the Transfer component to handle function-based classNames/styles
- Enhanced documentation with examples demonstrating the new functionality
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| components/transfer/index.tsx | Updated type definitions and added props merging for semantic styling functions |
| components/transfer/index.zh-CN.md | Updated Chinese documentation to reflect new function-based styling capabilities |
| components/transfer/index.en-US.md | Updated English documentation to reflect new function-based styling capabilities |
| components/transfer/demo/style-class.tsx | Added demo showcasing both object and function-based styling approaches |
| components/transfer/demo/style-class.md | Added documentation for the styling demo |
| components/transfer/tests/index.test.tsx | Added comprehensive tests for new function-based styling functionality |
| components/transfer/tests/snapshots/*.snap | Updated snapshots to include new demo output |
| components/transfer/Section.tsx | Updated prop types to use semantic names directly |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3 participants
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log