feat(slider): Support better customization with semantic classNames/styles as function by meet-student · Pull Request #54965 · ant-design/ant-design

meet-student · 2025-09-12T01:56:31Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog! Track your changes, like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	Support better customization with semantic classNames/styles as function
🇨🇳 Chinese	Support better customization with semantic classNames/styles as function

bolt-new-by-stackblitz · 2025-09-12T01:56:35Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-09-12T01:56:39Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

accesslint

There are accessibility issues in these changes.

components/slider/__tests__/__snapshots__/demo-extend.test.ts.snap

components/slider/__tests__/__snapshots__/demo.test.ts.snap

components/slider/__tests__/__snapshots__/demo-extend.test.ts.snap

components/slider/__tests__/__snapshots__/demo.test.ts.snap

accesslint · 2025-09-12T01:56:43Z

components/slider/__tests__/__snapshots__/demo.test.ts.snap

+          <div
+            class="ant-slider-step"
+          />
+          <div


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

components/slider/__tests__/__snapshots__/demo-extend.test.ts.snap

components/slider/__tests__/__snapshots__/demo.test.ts.snap

components/slider/__tests__/__snapshots__/demo-extend.test.ts.snap

accesslint · 2025-09-12T01:56:43Z

components/slider/__tests__/__snapshots__/demo-extend.test.ts.snap

+            <div
+              class="ant-slider-step"
+            />
+            <div


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

gemini-code-assist

Summary of Changes

Hello @meet-student, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the customization capabilities of the Slider component by introducing support for functional classNames and styles props. This allows for more flexible and dynamic styling, where the appearance of the slider can adapt based on its internal state or external properties, moving beyond static object-based styling. The changes include core logic updates, new demo examples, and comprehensive documentation to guide developers in utilizing this new feature.

Highlights

Enhanced Customization: The Slider component now supports classNames and styles props that can accept functions, enabling dynamic styling based on the component's current state or properties.
Dynamic Styling: These functions receive the component's props (e.g., disabled, vertical), allowing developers to apply conditional CSS classes or inline styles to various semantic parts of the slider (root, track, handle, rail).
New Demo and Documentation: A new demo (style-class.tsx) has been added to showcase this enhanced customization, accompanied by updated documentation in both English and Chinese to reflect the expanded API.
Internal Refactoring: The implementation leverages a new useMergeSemantic hook to efficiently combine and apply static and functional classNames and styles from different sources.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2025-09-12T01:57:29Z

👁 Visual Regression Report for PR #54965 Failed ❌

🎯 Target branch: next (a97235f)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 4 changed, 🆕 3 added

Expected (Branch next)	Actual (Current PR)	Diff
auto-complete-variant.compact.png	auto-complete-variant.compact.png
auto-complete-variant.dark.png	auto-complete-variant.dark.png
auto-complete-variant.default.png	auto-complete-variant.default.png
table-sticky.default.png	table-sticky.default.png
	slider-style-class.compact.png	🆕🆕🆕 Added 🆕🆕🆕
	slider-style-class.dark.png	🆕🆕🆕 Added 🆕🆕🆕
	slider-style-class.default.png	🆕🆕🆕 Added 🆕🆕🆕

Important

There are 7 diffs found in this PR: 🔄 4 changed, 🆕 3 added.
Please check all items:

Visual diff is acceptable

github-actions · 2025-09-12T01:57:55Z

gemini-code-assist

Code Review

This pull request introduces a valuable enhancement to the Slider component by allowing classNames and styles props to be functions. This enables more dynamic and conditional styling. The implementation is well-executed, leveraging a new useMergeSemantic hook that simplifies the component's logic for handling styles and classes. The changes are well-supported with a new demo, tests, and updated documentation. I've identified a couple of minor issues in the documentation related to incorrect anchor links, which I've commented on. Overall, this is a solid contribution.

components/slider/demo/style-class.md

components/slider/index.en-US.md

codecov · 2025-09-12T02:13:56Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (bb58080) to head (6c9d5bc).
⚠️ Report is 84 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #54965   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          793       793           
  Lines        14635     14659   +24     
  Branches      3889      3891    +2     
=========================================
+ Hits         14635     14659   +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

thinkasany · 2025-09-19T11:35:56Z

…tyles as function

pkg-pr-new · 2025-09-21T09:36:32Z

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@54965

commit: 6c9d5bc

codecov · 2025-09-21T09:38:19Z

Bundle Report

Changes will increase total bundle size by 7.92MB (211.32%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name	Size	Change
antd.min-array-push	11.67MB	7.92MB (211.32%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.js` (New)	6.13MB	6.13MB	100.0% 🚀
`antd.js` (New)	5.53MB	5.53MB	100.0% 🚀
~~`antd-with-locales.min.js`~~ (Deleted)	-2.06MB	0 bytes	-100.0% 🗑️
~~`antd.min.js`~~ (Deleted)	-1.69MB	0 bytes	-100.0% 🗑️

accesslint

There are accessibility issues in these changes.

components/slider/__tests__/__snapshots__/demo-extend.test.ts.snap

accesslint · 2025-09-25T16:05:45Z

components/slider/__tests__/__snapshots__/demo.test.ts.snap

+    <div
+      class="ant-slider-step"
+    />
+    <div


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

components/slider/__tests__/__snapshots__/demo.test.ts.snap

components/slider/__tests__/__snapshots__/demo-extend.test.ts.snap

meet-student · 2025-09-26T09:55:56Z

accesslint bot reviewed Sep 12, 2025

View reviewed changes

gemini-code-assist bot reviewed Sep 12, 2025

View reviewed changes

components/slider/demo/style-class.md Outdated Show resolved Hide resolved

components/slider/index.en-US.md Outdated Show resolved Hide resolved

components/slider/index.en-US.md Outdated Show resolved Hide resolved

meet-student mentioned this pull request Sep 13, 2025

Support better customization with semantic classNames/styles #54995

Closed

63 tasks

feat(slider): Support better customization with semantic classNames/s…

40b0675

…tyles as function

update demo and snap

6c9d5bc

accesslint bot reviewed Sep 25, 2025

View reviewed changes

zombieJ approved these changes Sep 28, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 28, 2025

zombieJ merged commit caf32cc into ant-design:next Sep 28, 2025
39 checks passed

meet-student deleted the slider branch October 1, 2025 02:47

zombieJ mentioned this pull request Nov 4, 2025

docs: changelog of 6.0.0-alpha.4 #55604

Merged

17 tasks

Uh oh!

Comments

Conversation

meet-student commented Sep 12, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Sep 12, 2025

Uh oh!

coderabbitai bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

accesslint bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

accesslint bot Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

accesslint bot Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions bot commented Sep 12, 2025 • edited by zombieJ Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #54965 Failed ❌

Uh oh!

github-actions bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

thinkasany commented Sep 19, 2025

Uh oh!

pkg-pr-new bot commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

accesslint bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

accesslint bot Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

meet-student commented Sep 26, 2025

Uh oh!

Uh oh!

coderabbitai bot commented Sep 12, 2025 •

edited

Loading

github-actions bot commented Sep 12, 2025 •

edited by zombieJ

Loading

github-actions bot commented Sep 12, 2025 •

edited

Loading

codecov bot commented Sep 12, 2025 •

edited

Loading

pkg-pr-new bot commented Sep 21, 2025 •

edited

Loading

codecov bot commented Sep 21, 2025 •

edited

Loading