feat(auto-complete): Support better customization with semantic classNames/styles as function#54959
feat(auto-complete): Support better customization with semantic classNames/styles as function#54959zombieJ merged 8 commits intoant-design:nextfrom meet-student:auto-complete
Conversation
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
👁 Visual Regression Report for PR #54959 Failed ❌
Important There are 4 diffs found in this PR: 🔄
|
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @meet-student, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly improves the customization capabilities of the AutoComplete component by allowing its classNames and styles props to accept functions. This change provides developers with greater flexibility to dynamically control the appearance and behavior of the component's internal elements based on its current state or properties, leading to more adaptable and responsive UI implementations.
Highlights
- Enhanced AutoComplete Customization: The AutoComplete component now supports dynamic customization of its internal semantic DOM elements. The classNames and styles props can now accept functions, allowing developers to apply classes and styles conditionally based on the component's current props.
- New Semantic Styling API Integration: This enhancement is powered by the integration of the useMergeSemantic hook and new type definitions (AutoCompleteClassNamesType, AutoCompleteStylesType), providing a structured way to manage component styling.
- Updated Documentation and Demos: New demo files (style-class.md, style-class.tsx) and updated API documentation (index.en-US.md, index.zh-CN.md) have been added to illustrate and explain the new customization capabilities.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
More templates
commit: |
Bundle ReportChanges will decrease total bundle size by 7.91MB (-67.85%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for function-based classNames and styles in the AutoComplete component, allowing for more dynamic customization. The implementation leverages a new useMergeSemantic hook to handle the merging of styles and classes. While the overall approach is sound and the new functionality is well-tested, there are some opportunities for improvement in the TypeScript typings to enhance type safety and remove the need for any type assertions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #54959 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 793 793
Lines 14651 14660 +9
Branches 3892 3893 +1
=========================================
+ Hits 14651 14660 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| const [options, setOptions] = React.useState([ | ||
| { value: 'aojunhao123', label: 'aojunhao123' }, | ||
| { value: 'thinkasany', label: 'thinkasany' }, | ||
| { value: 'Meet-student', label: 'Meet-student' }, |
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
…Names/styles as function
…Names/styles as function
|
| @@ -0,0 +1,71 @@ | |||
| import React from 'react'; | |||
…Names/styles as function (ant-design#54959) * feat(auto-complete): Support better customization with semantic classNames/styles as function * update demo * feat(auto-complete): Support better customization with semantic classNames/styles as function * update demo * update demo and snap * chore: opt with memo --------- Co-authored-by: 二货机器人 <[email protected]>
3 participants
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log