feat(tabs): Support better customization with semantic classNames/styles as function#54958
feat(tabs): Support better customization with semantic classNames/styles as function#54958zombieJ merged 3 commits intoant-design:nextfrom meet-student:tabs
Conversation
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
👁 Visual Regression Report for PR #54958 Failed ❌
Important There are 4 diffs found in this PR: 🔄
|
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @meet-student, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the flexibility of the Tabs component by introducing the ability to dynamically apply CSS classes and inline styles. Developers can now provide functions to the classNames and styles props, enabling conditional styling based on the component's properties. This change empowers more sophisticated and adaptive UI designs without modifying the component's core logic.
Highlights
- Enhanced Tabs Customization: The Tabs component now supports passing functions to its classNames and styles props, allowing for dynamic styling based on the component's current properties.
- New Demo and Documentation: A new demo (style-class.tsx) and corresponding documentation (style-class.md, index.en-US.md, index.zh-CN.md) have been added to illustrate the usage of function-based classNames and styles.
- Improved Type Definitions: Type definitions for TabsProps have been updated to correctly reflect the new function signature for classNames and styles, ensuring better type safety and developer experience.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable feature by allowing classNames and styles props on the Tabs component to accept functions, enabling more dynamic and powerful customization. The implementation is well-structured, including the refactoring of props into a BaseTabsProps interface. My review includes suggestions to enhance type safety in the new demo component, correct a duplicated line in the documentation, and improve the dependency array of a useMemo hook for better code clarity.
More templates
commit: |
Bundle ReportChanges will decrease total bundle size by 7.91MB (-67.85%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #54958 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 793 793
Lines 14640 14642 +2
Branches 3891 3891
=========================================
+ Hits 14640 14642 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -0,0 +1,80 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Tab 标签加个水平内间距
垂直的右边内容加上上间距，让水平和垂直间距看起来和谐一些
3 participants
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log