Skip to content

Comments

feat(InputNumber): support classNames and styles for component and ConfigProvider#53698

Merged
zombieJ merged 4 commits intonextfrom
cp-inputNumber
Apr 30, 2025
Merged

feat(InputNumber): support classNames and styles for component and ConfigProvider#53698
zombieJ merged 4 commits intonextfrom
cp-inputNumber

Conversation

@thinkasany
Copy link
Member

@thinkasany thinkasany commented Apr 29, 2025

🤔 This is a ...

📝 Change Log

Language Changelog
🇺🇸 English feat: ConfigProvider support classNames and styles for inputNumber
🇨🇳 Chinese feat: ConfigProvider support classNames and styles for inputNumber

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2025

👁 Visual Regression Report for PR #53698 Passed ✅

🎯 Target branch: next (91c2b99)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2025

Preview is ready

@thinkasany thinkasany mentioned this pull request Apr 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2025

size-limit report 📦

Path Size
dist/antd.min.js 498.52 KB (+417 B 🔺)
dist/antd-with-locales.min.js 589.37 KB (-377 B 🔽)

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 29, 2025

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6958fd1
Status: ✅  Deploy successful!
Preview URL: https://130b0699.ant-design.pages.dev
Branch Preview URL: https://cp-inputnumber.ant-design.pages.dev

View logs

@socket-security
Copy link

socket-security bot commented Apr 29, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​rc-component/​input-number@​1.0.0 ⏵ 1.1.080 +110010088 +7100

View full report

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 29, 2025

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53698

commit: 6958fd1

@codecov
Copy link

codecov bot commented Apr 29, 2025

Bundle Report

Changes will increase total bundle size by 7.77MB (207.31%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
antd.min-array-push 11.52MB 7.77MB (207.31%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.js (New) 6.06MB 6.06MB 100.0% 🚀
antd.js (New) 5.46MB 5.46MB 100.0% 🚀
antd-with-locales.min.js (Deleted) -2.06MB 0 bytes -100.0% 🗑️
antd.min.js (Deleted) -1.69MB 0 bytes -100.0% 🗑️

Files in antd-with-locales.js:

  • ./components/config-provider/context.ts → Total Size: 1.52kB

Files in antd.js:

  • ./components/config-provider/context.ts → Total Size: 1.52kB

@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (91c2b99) to head (6958fd1).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff            @@
##              next    #53698   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          783       783           
  Lines        14215     14216    +1     
  Branches      3737      3737           
=========================================
+ Hits         14215     14216    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

input: '输入框元素',
prefix: '前缀的包裹元素',
suffix: '后缀的包裹元素',
actions: '操作元素',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styles 覆盖一下,否则看不出来 actions 是什么:

截屏2025-04-30 10 32 15

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 30, 2025
@zombieJ zombieJ merged commit 75d8fa4 into next Apr 30, 2025
44 of 45 checks passed
@zombieJ zombieJ deleted the cp-inputNumber branch April 30, 2025 06:22
@Wxh16144 Wxh16144 changed the title feat: ConfigProvider support classNames and styles for inputNumber feat(InputNumber): support classNames and styles for component and ConfigProvider Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants