Skip to content

Comments

refactor: Update build tools#53390

Merged
zombieJ merged 4 commits intonextfrom
next-antd-tools
Apr 3, 2025
Merged

refactor: Update build tools#53390
zombieJ merged 4 commits intonextfrom
next-antd-tools

Conversation

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 2, 2025

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ⌨️ Accessibility improvement
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English MISC: Raise build target which will not support IE anymore.
🇨🇳 Chinese MISC: 提升构建目标版本,不再支持 IE。

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 2, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zombieJ zombieJ marked this pull request as draft April 2, 2025 13:58
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

👁 Visual Regression Report for PR #53390 Passed ✅

🎯 Target branch: next (284fce4)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Preview is ready

@petercat-assistant
Copy link

Walkthrough

This pull request refactors the build tools by updating the @ant-design/tools dependency to version 19.0.0, changing the TypeScript target to es2020, and modifying the Webpack configuration. These changes aim to improve the build process and drop support for Internet Explorer.

Changes

Files Summary
package.json Updated @ant-design/tools to version 19.0.0, modified scripts for compile and removed lint:deps.
tsconfig.json Changed TypeScript target from es6 to es2020.
webpack.config.js Updated import statement for getWebpackConfig from @ant-design/tools.

{
"compilerOptions": {
"target": "es6",
"target": "es2020",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the TypeScript target from es6 to es2020 may introduce compatibility issues with older environments. Ensure that all target environments support ES2020 features.

@socket-security
Copy link

socket-security bot commented Apr 2, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@ant-design/[email protected]

View full report↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

size-limit report 📦

Path Size
dist/antd.min.js 498.43 KB (-12.15 KB 🔽)
dist/antd-with-locales.min.js 587.98 KB (-14.73 KB 🔽)

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 2, 2025

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53390

commit: e6e07fd

@codecov
Copy link

codecov bot commented Apr 2, 2025

Bundle Report

Changes will decrease total bundle size by 200.11kB (-5.08%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.74MB -200.11kB (-5.08%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.min.js -101.0kB 2.06MB -4.68%
antd.min.js -99.1kB 1.68MB -5.56%

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 2, 2025

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: e6e07fd
Status: ✅  Deploy successful!
Preview URL: https://610d8480.ant-design.pages.dev
Branch Preview URL: https://next-antd-tools.ant-design.pages.dev

View logs

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (284fce4) to head (e6e07fd).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff            @@
##              next    #53390   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          780       780           
  Lines        14117     14117           
  Branches      3719      3719           
=========================================
  Hits         14117     14117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zombieJ zombieJ marked this pull request as ready for review April 3, 2025 02:54
@zombieJ zombieJ changed the title [WIP] refactor: Update build tools refactor: Update build tools Apr 3, 2025
@zombieJ zombieJ merged commit 6211b4b into next Apr 3, 2025
48 checks passed
@zombieJ zombieJ deleted the next-antd-tools branch April 3, 2025 03:02
@zombieJ zombieJ mentioned this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants