feat(Dropdown.Button): deprecated in favor of Space.Compact + Dropdown + Button by guoyunhe · Pull Request #53262 · ant-design/ant-design

guoyunhe · 2025-03-23T11:42:34Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	feat(Dropdown.Button): deprecated in favor of Space.Compact + Dropdown + Button
🇨🇳 Chinese	feat(Dropdown.Button): 废弃，建议使用 Space.Compact + Dropdown + Button

bolt-new-by-stackblitz · 2025-03-23T11:42:37Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-03-23T11:42:41Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

accesslint

There are accessibility issues in these changes.

accesslint · 2025-03-23T11:42:44Z

components/dropdown/demo/dropdown-button.tsx

+        <Button onClick={handleButtonClick}>With Tooltip</Button>
+      </Tooltip>
+      <Dropdown menu={menuProps} placement="bottomRight">
+        <Button loading />


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

github-actions · 2025-03-23T11:42:47Z

github-actions · 2025-03-23T11:42:49Z

👁 Visual Regression Report for PR #53262 Failed ❌

🎯 Target branch: next (a6418ef)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 4 changed

Expected (Branch next)	Actual (Current PR)	Diff
dropdown-icon-debug.compact.png	dropdown-icon-debug.compact.png
dropdown-icon-debug.dark.png	dropdown-icon-debug.dark.png
dropdown-icon-debug.default.png	dropdown-icon-debug.default.png
dropdown-loading.compact.png	dropdown-loading.compact.png

Important

There are 4 diffs found in this PR: 🔄 4 changed.
Please check all items:

Visual diff is acceptable

pkg-pr-new · 2025-03-23T11:46:21Z

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53262

commit: 9723d75

codecov · 2025-03-23T11:46:24Z

Bundle Report

Bundle size has no change ✅

codecov · 2025-03-23T12:10:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a6418ef) to head (9723d75).
Report is 1 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #53262   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          788       788           
  Lines        14368     14368           
  Branches      3785      3785           
=========================================
  Hits         14368     14368

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zombieJ · 2025-03-28T07:42:50Z

components/dropdown/index.zh-CN.md


 ### Dropdown.Button

+<!-- prettier-ignore -->


文档里移除掉吧，next 里不需要了

thinkasany · 2025-03-28T13:32:23Z

› 2 snapshots failed from 1 test suite. Inspect your code changes or run npm run test:site -- -u to update them.

components/dropdown/index.zh-CN.md

thinkasany · 2025-06-10T08:59:03Z

覆盖率掉了

…n + Button

accesslint bot reviewed Mar 23, 2025

View reviewed changes

guoyunhe force-pushed the next-deprecate-dropdown-button branch from 0b0b5cb to 4551fb6 Compare March 23, 2025 11:50

guoyunhe force-pushed the next-deprecate-dropdown-button branch 2 times, most recently from ffbcc13 to 234b76b Compare March 28, 2025 06:57

zombieJ reviewed Mar 28, 2025

View reviewed changes

guoyunhe force-pushed the next-deprecate-dropdown-button branch from 234b76b to 5a84364 Compare March 28, 2025 13:17

thinkasany added the skip-verify-files label Mar 28, 2025

guoyunhe force-pushed the next-deprecate-dropdown-button branch from 5a84364 to eb4705f Compare March 31, 2025 03:59

Wxh16144 reviewed Apr 3, 2025

View reviewed changes

components/dropdown/index.zh-CN.md Show resolved Hide resolved

guoyunhe force-pushed the next-deprecate-dropdown-button branch 2 times, most recently from 4c3edcf to 1eb0af1 Compare June 10, 2025 07:45

feat(Dropdown.Button): deprecated in favor of Space.Compact + Dropdow…

9723d75

…n + Button

guoyunhe force-pushed the next-deprecate-dropdown-button branch from 1eb0af1 to 9723d75 Compare June 10, 2025 09:02

zombieJ approved these changes Jun 10, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 10, 2025

zombieJ merged commit 7aac0a4 into ant-design:next Jun 10, 2025
39 checks passed

This was referenced Jun 10, 2025

chore: [v6] rm Dropdown.Button #53793

Merged

Ant Design v6 tasks #52115

Closed

dosubot bot mentioned this pull request Jun 22, 2025

i need over hidden dropdown in container #54171

Closed

Uh oh!

Comments

Conversation

guoyunhe commented Mar 23, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Mar 23, 2025

Uh oh!

coderabbitai bot commented Mar 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

accesslint bot left a comment

Choose a reason for hiding this comment

Uh oh!

accesslint bot Mar 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 23, 2025 • edited by zombieJ Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #53262 Failed ❌

Uh oh!

pkg-pr-new bot commented Mar 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Uh oh!

codecov bot commented Mar 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zombieJ Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

guoyunhe Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

thinkasany commented Mar 28, 2025

Uh oh!

Uh oh!

thinkasany commented Jun 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Mar 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Mar 23, 2025 •

edited

Loading

github-actions bot commented Mar 23, 2025 •

edited by zombieJ

Loading

pkg-pr-new bot commented Mar 23, 2025 •

edited

Loading

codecov bot commented Mar 23, 2025 •

edited

Loading

codecov bot commented Mar 23, 2025 •

edited

Loading