feat(TreeSelect): support `classNames` and `styles` for component and ConfigProvider by thinkasany · Pull Request #53229 · ant-design/ant-design

thinkasany · 2025-03-20T09:45:17Z

🤔 This is a ...

🆕 New feature

wait for https://github.com/react-component/tree-select/pull/638/files

📝 Change Log

Language	Changelog
🇺🇸 English	feat: ConfigProvider support classNames and styles for treeSelect
🇨🇳 Chinese	feat: ConfigProvider support classNames and styles for treeSelect

bolt-new-by-stackblitz · 2025-03-20T09:45:20Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-03-20T09:45:26Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-20T09:45:29Z

👁 Visual Regression Report for PR #53229 Passed ✅

🎯 Target branch: next (ffe0cce)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

github-actions · 2025-03-20T09:45:30Z

petercat-assistant · 2025-03-20T09:45:32Z

Walkthrough

This pull request introduces a new feature that enhances the ConfigProvider to support classNames and styles for the TreeSelect component. This allows for more customizable styling and class naming, improving the flexibility and usability of the component.

Changes

Files	Summary
components/config-provider/context.ts	Updated `TreeSelectConfig` to include `classNames` and `styles` properties.
components/tree-select/demo/_semantic.tsx	Added a new demo file showcasing the semantic DOM structure for `TreeSelect`.
components/tree-select/index.en-US.md, components/tree-select/index.zh-CN.md	Added documentation for the semantic DOM in both English and Chinese.
components/tree-select/index.tsx	Enhanced `TreeSelectProps` to support `classNames` and `styles`, and integrated these into the component logic.
package.json	Updated the version of `@rc-component/select` dependency.

components/tree-select/demo/_semantic.tsx

github-actions · 2025-03-20T09:48:06Z

size-limit report 📦

Path	Size
`dist/antd.min.js`	510.07 KB (+99 B 🔺)
`dist/antd-with-locales.min.js`	601.05 KB (+93 B 🔺)

pkg-pr-new · 2025-03-20T09:48:58Z

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53229

commit: 944f70f

codecov · 2025-03-20T09:51:34Z

Bundle Report

Changes will decrease total bundle size by 7.83MB (-66.54%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.94MB	-7.83MB (-66.54%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.min.js` (New)	2.16MB	2.16MB	100.0% 🚀
`antd.min.js` (New)	1.78MB	1.78MB	100.0% 🚀
~~`antd-with-locales.js`~~ (Deleted)	-6.18MB	0 bytes	-100.0% 🗑️
~~`antd.js`~~ (Deleted)	-5.58MB	0 bytes	-100.0% 🗑️

Files in antd-with-locales.min.js:

./components/config-provider/context.ts → Total Size: 1.51kB

Files in antd.min.js:

./components/config-provider/context.ts → Total Size: 1.51kB

cloudflare-workers-and-pages · 2025-03-20T09:54:16Z

Deploying ant-design with Cloudflare Pages

Latest commit:	`944f70f`
Status:	✅ Deploy successful!
Preview URL:	https://7fdcf039.ant-design.pages.dev
Branch Preview URL:	https://cp-treeselect.ant-design.pages.dev

View logs

codecov · 2025-03-20T10:05:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8790680) to head (944f70f).
Report is 3 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #53229   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          778       779    +1     
  Lines        14028     14068   +40     
  Branches      3683      3696   +13     
=========================================
+ Hits         14028     14068   +40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

components/tree-select/__tests__/index.test.tsx

socket-security · 2025-03-21T14:32:49Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

zombieJ · 2025-03-25T02:10:07Z

components/tree-select/demo/_semantic.tsx

@@ -0,0 +1,105 @@
+import React from 'react';


petercat-assistant bot reviewed Mar 20, 2025

View reviewed changes

components/tree-select/demo/_semantic.tsx Outdated Show resolved Hide resolved

thinkasany mentioned this pull request Mar 20, 2025

Ant Design v6 tasks #52115

Closed

graphite-app bot reviewed Mar 20, 2025

View reviewed changes

components/tree-select/__tests__/index.test.tsx Outdated Show resolved Hide resolved

thinkasany force-pushed the cp-treeSelect branch from a69422d to 28651fa Compare March 21, 2025 14:31

thinkasany force-pushed the cp-treeSelect branch from 6f664f5 to 8b58df2 Compare March 21, 2025 14:57

feat: ConfigProvider support classNames and styles for treeSelect

c4ef002

thinkasany force-pushed the cp-treeSelect branch from 9807765 to 3433f7e Compare March 24, 2025 06:03

fix

ec5008a

thinkasany force-pushed the cp-treeSelect branch from 3433f7e to ec5008a Compare March 24, 2025 06:47

thinkasany added 2 commits March 24, 2025 21:23

fix

c863607

fix

28ec820

zombieJ reviewed Mar 25, 2025

View reviewed changes

components/tree-select/demo/_semantic.tsx

@@ -0,0 +1,105 @@

import React from 'react';

Copy link

Member

zombieJ Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinkasany added 3 commits March 25, 2025 11:01

update zIndex

0de6a0c

fix

b9e8b43

add test

944f70f

zombieJ approved these changes Mar 25, 2025

View reviewed changes

zombieJ merged commit d5f0fc1 into next Mar 25, 2025
44 checks passed

zombieJ deleted the cp-treeSelect branch March 25, 2025 11:14

Wxh16144 changed the title ~~feat: ConfigProvider support classNames and styles for treeSelect~~ feat(TreeSelect): support classNames and styles for component and ConfigProvider Nov 28, 2025

Uh oh!

Comments

Conversation

thinkasany commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 This is a ...

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Mar 20, 2025

Uh oh!

coderabbitai bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #53229 Passed ✅

Uh oh!

github-actions bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petercat-assistant bot commented Mar 20, 2025

Walkthrough

Changes

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

pkg-pr-new bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

cloudflare-workers-and-pages bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying ant-design with Cloudflare Pages

Uh oh!

codecov bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

socket-security bot commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zombieJ Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thinkasany commented Mar 20, 2025 •

edited

Loading

coderabbitai bot commented Mar 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Mar 20, 2025 •

edited

Loading

github-actions bot commented Mar 20, 2025 •

edited

Loading

github-actions bot commented Mar 20, 2025 •

edited

Loading

pkg-pr-new bot commented Mar 20, 2025 •

edited

Loading

codecov bot commented Mar 20, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Mar 20, 2025 •

edited

Loading

codecov bot commented Mar 20, 2025 •

edited

Loading

socket-security bot commented Mar 21, 2025 •

edited

Loading