feat(Form): support `classNames` and `styles` for component and ConfigProvider by thinkasany · Pull Request #53226 · ant-design/ant-design

thinkasany · 2025-03-20T06:49:42Z

🤔 This is a ...

🆕 New feature

📝 Change Log

Language	Changelog
🇺🇸 English	feat: ConfigProvider support classNames and styles for form
🇨🇳 Chinese	feat: ConfigProvider support classNames and styles for form

bolt-new-by-stackblitz · 2025-03-20T06:49:44Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-03-20T06:49:49Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-20T06:49:52Z

github-actions · 2025-03-20T06:49:53Z

👁 Visual Regression Report for PR #53226 Passed ✅

🎯 Target branch: next (666cebb)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

accesslint

There are accessibility issues in these changes.

components/form/demo/_semantic.tsx

petercat-assistant · 2025-03-20T06:49:56Z

Walkthrough

This pull request introduces a new feature to the ConfigProvider, allowing support for classNames and styles in forms. This enhancement provides more flexibility in styling and customizing forms within the Ant Design framework.

Changes

Files	Summary
components/config-provider/context.ts	Updated `FormConfig` to include `classNames` and `styles`.
components/config-provider/index.en-US.md, components/config-provider/index.zh-CN.md	Documentation updated to reflect new `classNames` and `styles` support for forms.
components/form/Form.tsx, components/form/FormItemInput.tsx, components/form/FormItemLabel.tsx	Integrated `classNames` and `styles` into form components, utilizing context for styling.
components/form/tests/index.test.tsx	Added tests to verify the new `classNames` and `styles` functionality.
components/form/context.tsx	Extended `FormContextProps` to include `classNames` and `styles`.
components/form/demo/_semantic.tsx	Added a demo to showcase the semantic DOM structure with the new styling options.
components/form/index.en-US.md, components/form/index.zh-CN.md	Added documentation for semantic DOM with examples.

components/form/Form.tsx

cloudflare-workers-and-pages · 2025-03-20T06:50:44Z

Deploying ant-design with Cloudflare Pages

Latest commit:	`11b3d02`
Status:	✅ Deploy successful!
Preview URL:	https://9b236025.ant-design.pages.dev
Branch Preview URL:	https://cp-form.ant-design.pages.dev

View logs

github-actions · 2025-03-20T06:52:32Z

size-limit report 📦

Path	Size
`dist/antd.min.js`	507.05 KB (+94 B 🔺)
`dist/antd-with-locales.min.js`	599.51 KB (+80 B 🔺)

pkg-pr-new · 2025-03-20T06:53:18Z

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53226

commit: 11b3d02

codecov · 2025-03-20T06:54:24Z

Bundle Report

Changes will increase total bundle size by 698 bytes (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.9MB	698 bytes (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.min.js`	349 bytes	2.14MB	0.02%
`antd.min.js`	349 bytes	1.76MB	0.02%

Files in antd-with-locales.min.js:

./components/config-provider/context.ts → Total Size: 1.51kB

Files in antd.min.js:

./components/config-provider/context.ts → Total Size: 1.51kB

codecov · 2025-03-20T07:11:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (666cebb) to head (11b3d02).
Report is 2 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #53226   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          778       778           
  Lines        13998     14000    +2     
  Branches      3670      3670           
=========================================
+ Hits         13998     14000    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zombieJ · 2025-03-20T07:27:37Z

components/form/demo/_semantic.tsx

+  cn: {
+    root: '根元素',
+    label: '标签元素',
+    content: '内容元素',


感觉是我没说清楚，这个应该是挪到对应标记的位置。如果是 col 上的话，我们未来可以加 labelCol 和 wrapperCol 语义化结构：

done. 已改造完成

accesslint bot reviewed Mar 20, 2025

View reviewed changes

components/form/demo/_semantic.tsx Show resolved Hide resolved

petercat-assistant bot reviewed Mar 20, 2025

View reviewed changes

components/form/Form.tsx Show resolved Hide resolved

feat: ConfigProvider support classNames and styles for form

b8ccb1d

thinkasany force-pushed the cp-form branch from 469b628 to b8ccb1d Compare March 20, 2025 06:50

thinkasany mentioned this pull request Mar 20, 2025

Ant Design v6 tasks #52115

Closed

zombieJ reviewed Mar 20, 2025

View reviewed changes

update

11b3d02

zombieJ approved these changes Mar 21, 2025

View reviewed changes

zombieJ merged commit 3796a7f into next Mar 21, 2025
44 checks passed

zombieJ deleted the cp-form branch March 21, 2025 03:06

Wxh16144 changed the title ~~feat: ConfigProvider support classNames and styles for form~~ feat(Form): support classNames and styles for component and ConfigProvider Nov 28, 2025

dosubot bot mentioned this pull request Feb 3, 2026

🧐[问题] ProTable 组件的 search 属性中配置optionRender 为false 时 ant-design/pro-components#9433

Open

Uh oh!

Comments

Conversation

thinkasany commented Mar 20, 2025

🤔 This is a ...

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Mar 20, 2025

Uh oh!

coderabbitai bot commented Mar 20, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #53226 Passed ✅

Uh oh!

accesslint bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

petercat-assistant bot commented Mar 20, 2025

Walkthrough

Changes

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying ant-design with Cloudflare Pages

Uh oh!

github-actions bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

pkg-pr-new bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zombieJ Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

thinkasany Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Mar 20, 2025 •

edited

Loading

github-actions bot commented Mar 20, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Mar 20, 2025 •

edited

Loading

github-actions bot commented Mar 20, 2025 •

edited

Loading

pkg-pr-new bot commented Mar 20, 2025 •

edited

Loading

codecov bot commented Mar 20, 2025 •

edited

Loading

codecov bot commented Mar 20, 2025 •

edited

Loading