feat(Splitter): support classNames and styles#53225
feat(Splitter): support classNames and styles#53225zombieJ merged 13 commits intoant-design:nextfrom
classNames and styles#53225Conversation
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
|
👁 Visual Regression Report for PR #53225 Failed ❌
Important There are 3 diffs found in this PR: 🔄
|
WalkthroughThis pull request introduces a new feature to the Splitter component, allowing it to support semantic classNames and styles. This enhancement provides more flexibility in customizing the appearance and behavior of the Splitter component by enabling the use of custom styles and class names. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
More templates
commit: |
Bundle ReportChanges will increase total bundle size by 1.36kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
Files in
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #53225 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 778 778
Lines 13998 14017 +19
Branches 3670 3676 +6
=========================================
+ Hits 13998 14017 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
其实还有一个操作，就是 git branch -D 本地原来的分支，然后 git checkout next，重新 git checkout -b 原来的分支，cherrypick处理完commit 最后push -f。就保留了原来的 PR 和 分支，并且修整了干净的commit。作用大概就是可以保留原来 其他 reviewers 的评论~ 看选择 |
|
🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR). 🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。 
|
|
|
||
| function mergeClassNames<T extends NestClassNames>(...classNamesList: (T | undefined)[]) { | ||
| // Init array for performance saving | ||
| const keyList: string[] = []; |
There was a problem hiding this comment.
这样没有省性能，比如有两个 classNames:
A {
root: 'a',
}
B {
body: 'b'
}原本分别遍历 Object.keys 时，只需要遍历 A.a + B.b。现在变成了 A.a + A.b + B.a + B.b。反而耗费了性能。
Wxh16144
changed the title
classNames and styles
3 participants
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log