feat(Button): support `classNames` and `styles` for component and ConfigProvider by thinkasany · Pull Request #53055 · ant-design/ant-design

thinkasany · 2025-03-05T07:36:58Z

🤔 This is a ...

🆕 New feature

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	feat: ConfigProvider support classNames and styles for button
🇨🇳 Chinese	feat: ConfigProvider support classNames and styles for button

bolt-new-by-stackblitz · 2025-03-05T07:37:01Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2025-03-05T07:37:10Z

github-actions · 2025-03-05T07:37:10Z

👁 Visual Regression Report for PR #53055 Failed ❌

🎯 Target branch: next (3fa9a51)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 17 changed, 🆕 3 added

Expected (Branch next)	Actual (Current PR)	Diff
button-debug-icon.compact.png	button-debug-icon.compact.png
button-debug-icon.dark.png	button-debug-icon.dark.png
button-debug-icon.default.png	button-debug-icon.default.png
table-fixed-columns-header.compact.png	table-fixed-columns-header.compact.png
table-fixed-columns-header.dark.png	table-fixed-columns-header.dark.png
table-fixed-columns-header.default.png	table-fixed-columns-header.default.png
table-fixed-columns.compact.png	table-fixed-columns.compact.png
table-fixed-columns.dark.png	table-fixed-columns.dark.png

Warning

There are more diffs not shown in the table. Please check the Full Report for details.

Important

There are 20 diffs found in this PR: 🔄 17 changed, 🆕 3 added.
Please check all items:

Checked all diffs in the full report
Visual diff is acceptable

github-actions · 2025-03-05T07:39:56Z

size-limit report 📦

Path	Size
`dist/antd.min.js`	507.58 KB (+983 B 🔺)
`dist/antd-with-locales.min.js`	599.22 KB (-1002 B 🔽)

codecov · 2025-03-05T07:40:40Z

Bundle Report

Changes will increase total bundle size by 2.05kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	11.72MB	2.05kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.js`	1.02kB	6.16MB	0.02%
`antd.js`	1.02kB	5.56MB	0.02%

pkg-pr-new · 2025-03-05T07:40:44Z

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53055

commit: c3798dc

cloudflare-workers-and-pages · 2025-03-05T07:46:09Z

Deploying ant-design with Cloudflare Pages

Latest commit:	`c3798dc`
Status:	✅ Deploy successful!
Preview URL:	https://28421bd5.ant-design.pages.dev
Branch Preview URL:	https://cp-button.ant-design.pages.dev

View logs

codecov · 2025-03-05T07:56:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c34eda6) to head (c3798dc).
Report is 2 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #53055   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          772       773    +1     
  Lines        13897     13903    +6     
  Branches      3644      3647    +3     
=========================================
+ Hits         13897     13903    +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

components/button/button.tsx

components/button/buttonHelpers.tsx

components/button/button.tsx

components/alert/__tests__/__snapshots__/demo-extend.test.ts.snap

components/button/buttonHelpers.tsx

thinkasany mentioned this pull request Mar 5, 2025

Ant Design v6 tasks #52115

Closed

zombieJ reviewed Mar 5, 2025

View reviewed changes

components/button/button.tsx Outdated Show resolved Hide resolved

thinkasany force-pushed the cp-button branch from f04a018 to 048925d Compare March 5, 2025 09:42

li-jia-nan reviewed Mar 5, 2025

View reviewed changes

thinkasany force-pushed the cp-button branch from 68db5bf to a16f4d4 Compare March 6, 2025 03:06

li-jia-nan reviewed Mar 6, 2025

View reviewed changes

components/button/buttonHelpers.tsx Outdated Show resolved Hide resolved

thinkasany added 2 commits March 6, 2025 17:26

feat: ConfigProvider support classNames and styles for button

0ad1da6

improve

5cd7f4e

thinkasany force-pushed the cp-button branch from ff2fe2e to 5cd7f4e Compare March 6, 2025 09:26

fix

c3798dc

zombieJ approved these changes Mar 6, 2025

View reviewed changes

zombieJ merged commit e82d4c7 into next Mar 6, 2025
42 checks passed

zombieJ deleted the cp-button branch March 6, 2025 13:46

Wxh16144 changed the title ~~feat: ConfigProvider support classNames and styles for button~~ feat(Button): support classNames and styles for component and ConfigProvider Nov 28, 2025

dosubot bot mentioned this pull request Jan 13, 2026

Button 子元素自定义的class被去掉 #56591

Closed

thinkasany mentioned this pull request Jan 13, 2026

fix: improvement style order #56597

Merged

17 tasks

Uh oh!

Comments

Conversation

thinkasany commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2025 • edited by thinkasany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #53055 Failed ❌

Uh oh!

github-actions bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

pkg-pr-new bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying ant-design with Cloudflare Pages

Uh oh!

codecov bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thinkasany commented Mar 5, 2025 •

edited

Loading

github-actions bot commented Mar 5, 2025 •

edited

Loading

github-actions bot commented Mar 5, 2025 •

edited by thinkasany

Loading

github-actions bot commented Mar 5, 2025 •

edited

Loading

codecov bot commented Mar 5, 2025 •

edited

Loading

pkg-pr-new bot commented Mar 5, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Mar 5, 2025 •

edited

Loading

codecov bot commented Mar 5, 2025 •

edited

Loading