Skip to content

Comments

refactor: context hook of rate#52883

Merged
zombieJ merged 1 commit intonextfrom
cp-rate
Feb 19, 2025
Merged

refactor: context hook of rate#52883
zombieJ merged 1 commit intonextfrom
cp-rate

Conversation

@thinkasany
Copy link
Member

@thinkasany thinkasany commented Feb 19, 2025

中文版模板 / Chinese template

🤔 This is a ...

  • 🛠 Refactoring

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English -
🇨🇳 Chinese -

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Feb 19, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025 •
edited
Loading

Preview is ready

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025 •
edited by thinkasany
Loading

👁 Visual Regression Report for PR #52883 Failed ❌

🎯 Target branch: next (ab4304c)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 24 changed

Expected (Branch next) Actual (Current PR) Diff
button-component-token.compact.png button-component-token.compact.png button-component-token.compact.png button-component-token.compact.png
button-component-token.compact.png button-component-token.compact.png button-component-token.compact.css-var.png button-component-token.compact.css-var.png
button-component-token.dark.png button-component-token.dark.png button-component-token.dark.png button-component-token.dark.png
button-component-token.dark.png button-component-token.dark.png button-component-token.dark.css-var.png button-component-token.dark.css-var.png
button-component-token.default.png button-component-token.default.png button-component-token.default.png button-component-token.default.png
button-component-token.default.png button-component-token.default.png button-component-token.default.css-var.png button-component-token.default.css-var.png
button-debug-color-variant.compact.png button-debug-color-variant.compact.png button-debug-color-variant.compact.png button-debug-color-variant.compact.png
button-debug-color-variant.compact.png button-debug-color-variant.compact.png button-debug-color-variant.compact.css-var.png button-debug-color-variant.compact.css-var.png

Warning

There are more diffs not shown in the table. Please check the Full Report for details.

Important

There are 24 diffs found in this PR: 🔄 24 changed.
Please check all items:

  • Checked all diffs in the full report
  • Visual diff is acceptable

@petercat-assistant
Copy link

petercat-assistant bot commented Feb 19, 2025

Walkthrough

This pull request refactors the context hook used in the Rate component. The changes involve replacing ConfigContext with useComponentConfig to manage configuration settings, which affects how styles and class names are merged and applied.

Changes

Files Summary
components/rate/index.tsx Replaced ConfigContext with useComponentConfig for configuration management, affecting style and class name merging.

petercat-assistant[bot]
petercat-assistant bot reviewed Feb 19, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025

size-limit report 📦

Path Size
dist/antd.min.js 510.75 KB (+1 B 🔺)
dist/antd-with-locales.min.js 598.61 KB (+3 B 🔺)

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 19, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52883

commit: 638a985

@codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 186 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 11.64MB -186 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.js -93 bytes 6.07MB -0.0%
antd.js -93 bytes 5.57MB -0.0%

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 19, 2025

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: 638a985
Status: ✅  Deploy successful!
Preview URL: https://ca06e5b0.ant-design.pages.dev
Branch Preview URL: https://cp-rate.ant-design.pages.dev

View logs

@codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f45cd8b) to head (638a985).
Report is 3 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #52883   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          767       767           
  Lines        13811     13811           
  Branches      3620      3620           
=========================================
  Hits         13811     13811

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 40c11ee into next Feb 19, 2025
47 checks passed
@zombieJ zombieJ deleted the cp-rate branch February 19, 2025 03:16
@thinkasany thinkasany mentioned this pull request Feb 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zombieJ zombieJ zombieJ approved these changes

+1 more reviewer

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thinkasany @zombieJ