feat(Breadcrumb): support classNames and styles for component and ConfigProvider#52859
Merged
feat(Breadcrumb): support classNames and styles for component and ConfigProvider#52859
classNames and styles for component and ConfigProvider#52859Conversation
|
|
Contributor
|
|
Contributor
👁 Visual Regression Report for PR #52859 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
More templates
commit: |
Bundle ReportChanges will increase total bundle size by 7.91MB (210.69%) ⬆️
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
Files in
Files in
|
thinkasany
force-pushed
the
cp-breadcrumb
branch
from
4371ff8 to
6db21ff
Compare
Deploying ant-design with
|
| Latest commit: |
f08f684
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6d7b0d55.ant-design.pages.dev |
| Branch Preview URL: | https://cp-breadcrumb.ant-design.pages.dev |
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #52859 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 765 766 +1
Lines 13803 13812 +9
Branches 3620 3620
=========================================
+ Hits 13803 13812 +9 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Feb 18, 2025
components/breadcrumb/Breadcrumb.tsx
Outdated
| return cloneElement(element, (oriProps) => ({ | ||
| separator: isLastItem ? '' : separator, | ||
| className: classNames(oriProps?.className, mergedClassNames?.item), | ||
| style: { ...mergedStyles?.item, ...oriProps?.style }, |
Member
There was a problem hiding this comment.
不太对，item 的位置应该是 li 不是里面的东西。BreadcrumbItem 的 render 会额外多包一层，所以这个直接传下去的位置是不对的：
zombieJ
approved these changes
Feb 18, 2025
Wxh16144
changed the title
classNames and styles for component and ConfigProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
📝 Change Log