Conversation
|
|
Contributor
👁 Visual Regression Report for PR #52823 Failed ❌
Warning There are more diffs not shown in the table. Please check the Full Report for details. Important There are 96 diffs found in this PR: 🔄
|
Contributor
|
|
WalkthroughThis pull request introduces a new feature to the ConfigProvider component, enabling support for Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
Closed
Contributor
size-limit report 📦
|
More templates
commit: |
Bundle ReportChanges will decrease total bundle size by 7.9MB (-67.79%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
Files in
Files in
|
Deploying ant-design with
|
| Latest commit: |
64f31cd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5116f416.ant-design.pages.dev |
| Branch Preview URL: | https://cp-spin.ant-design.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #52823 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 765 765
Lines 13799 13803 +4
Branches 3617 3620 +3
=========================================
+ Hits 13799 13803 +4 ☔ View full report in Codecov by Sentry. |
Member
|
最好搞两个例子，现在 root 这解释其实不如直接 hover 能看到效果的比较好： 
|
zombieJ
reviewed
Feb 17, 2025
components/spin/Indicator/Looper.tsx
Outdated
| <span className={classNames(holderClassName, percent > 0 && hideClassName)}> | ||
| <span className={classNames(dotClassName, `${prefixCls}-dot-spin`)}> | ||
| <span | ||
| className={classNames(dotClassName, className, `${prefixCls}-dot-spin`)} |
Member
There was a problem hiding this comment.
自定义的 indicator 是放在最外侧，那这边的 className 也是应该在最外侧才对
zombieJ
approved these changes
Feb 17, 2025
Wxh16144
changed the title
classNames and styles for component and ConfigProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
中文版模板 / Chinese template
🤔 This is a ...
📝 Change Log