feat(Message): support classNames and styles for component and ConfigProvider#52793
Merged
feat(Message): support classNames and styles for component and ConfigProvider#52793
classNames and styles for component and ConfigProvider#52793Conversation
|
|
Contributor
|
|
Contributor
👁 Visual Regression Report for PR #52793 Failed ❌
Important There are 2 diffs found in this PR: 🔄
|
WalkthroughThis pull request introduces a new feature to the ConfigProvider, allowing support for classnames and styles specifically for messages. The changes include updates to type definitions, component configurations, and documentation to accommodate the new styling capabilities for message components. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
Closed
Contributor
size-limit report 📦
|
More templates
commit: |
Bundle ReportChanges will increase total bundle size by 6.35kB (0.05%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
Files in
Files in
|
Deploying ant-design with
|
| Latest commit: |
5d44b54
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6e247074.ant-design.pages.dev |
| Branch Preview URL: | https://cp-message.ant-design.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #52793 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 765 765
Lines 13790 13798 +8
Branches 3612 3616 +4
=========================================
+ Hits 13790 13798 +8 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Feb 14, 2025
components/message/PurePanel.tsx
Outdated
| const iconElement = icon || (type && TypeIcon[type]); | ||
| const iconNode: React.ReactNode = cloneElement(iconElement, { | ||
| className: classNames( | ||
| React.isValidElement(iconElement) |
Member
There was a problem hiding this comment.
改造一下 cloneElement 吧，支持 renderProps 入参为原始的 props，这样可以少写一次 React.isValidElement
zombieJ
reviewed
Feb 14, 2025
components/message/PurePanel.tsx
Outdated
| : '', | ||
| PureContentClassNames?.icon, | ||
| ), | ||
| style: { ...styles?.icon }, |
thinkasany
force-pushed
the
cp-message
branch
from
e9d090d to
4ac977b
Compare
zombieJ
reviewed
Feb 14, 2025
components/message/PurePanel.tsx
Outdated
| type, | ||
| icon, | ||
| children, | ||
| classNames: PureContentClassNames, |
Member
There was a problem hiding this comment.
一般组件才会大写，这里不用大写。可以写成 propsClassNames
zombieJ
reviewed
Feb 14, 2025
components/message/PurePanel.tsx
Outdated
| }) => { | ||
| const iconElement = icon || (type && TypeIcon[type]); | ||
| const iconNode: React.ReactNode = cloneElement(iconElement, (currentProps) => ({ | ||
| className: classNames(currentProps?.className, PureContentClassNames?.icon), |
Member
There was a problem hiding this comment.
这里应该是不需要 ?. 的，能执行到这个函数是一定有 props 的
zombieJ
approved these changes
Feb 14, 2025
Wxh16144
changed the title
classNames and styles for component and ConfigProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
📝 Change Log