Skip to content

Comments

feat: [v6] Retire deprecated api for typography#52472

Merged
thinkasany merged 2 commits intonextfrom
v6-kiner-retire-deprecated-api-typography
Jan 20, 2025
Merged

feat: [v6] Retire deprecated api for typography#52472
thinkasany merged 2 commits intonextfrom
v6-kiner-retire-deprecated-api-typography

Conversation

@kiner-tang
Copy link
Member

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English Retire deprecated api for typography
🇨🇳 Chinese 废弃 api 退休

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2025

Preview is ready

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2025

👁 Visual Regression Report for PR #52472 Failed ❌

🎯 Target branch: next (c4ea4db)
📖 View Full Report ↗︎
📊 Summary: 🔄 1 changed

Expected (Branch next) Actual (Current PR) Diff
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png

Important

There are 1 diffs found in this PR: 🔄 1 changed.
Please check all items:

  • Visual diff is acceptable

@petercat-assistant
Copy link

Walkthrough

This pull request focuses on retiring deprecated APIs related to typography in the Ant Design library. The changes involve removing the setContentRef property and associated warnings, streamlining the usage of ref in typography components.

Changes

Files Summary
components/typography/Typography.tsx Removed deprecated setContentRef property and related warning logic. Simplified ref handling by using ref directly.
components/typography/tests/index.test.tsx Removed test cases related to the deprecated setContentRef property.

@kiner-tang kiner-tang mentioned this pull request Jan 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2025

size-limit report 📦

Path Size
dist/antd.min.js 496.77 KB (-25 B 🔽)
dist/antd-with-locales.min.js 565.14 KB (-34 B 🔽)

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 18, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52472

commit: 456b28f

@codecov
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b598467) to head (456b28f).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff            @@
##              next    #52472   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          760       760           
  Lines        13677     13673    -4     
  Branches      3575      3573    -2     
=========================================
- Hits         13677     13673    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 20, 2025

@thinkasany thinkasany merged commit 921caf9 into next Jan 20, 2025
40 of 41 checks passed
@thinkasany thinkasany deleted the v6-kiner-retire-deprecated-api-typography branch January 20, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants