feat: improve Semantic for Drawer#52247
Conversation
|
|
👁 Visual Regression Report for PR #52247 Failed ❌
Important There are 5 diffs found in this PR: 🔄
|
|
|
WalkthroughThis pull request introduces enhancements to the Drawer component by improving its semantic structure. It adds new class names and styles for various parts of the Drawer, such as the title, extra, and root elements. Additionally, it includes tests to verify the application of custom styles and updates the semantic demo to reflect these changes. Changes
|
More templates
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #52247 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 760 760
Lines 13682 13684 +2
Branches 3572 3574 +2
=========================================
+ Hits 13682 13684 +2 ☔ View full report in Codecov by Sentry. |
|
|
||
| const locales = { | ||
| cn: { | ||
| root: '根元素', |
There was a problem hiding this comment.
按照之前的讨论，content 是不是改叫 section 了？
There was a problem hiding this comment.
这里应该不用，content 其实语义是可以的。section 是为了解决之前detail那种，太泛不好包裹 title、description 的。
card.meta，list.meta这种，
There was a problem hiding this comment.
content 是在 body 下面，而 body 是和 header 同级。不应该是作为最大外容器的
There was a problem hiding this comment.
经过激烈的讨论，最终确定可以换成 section，都是用于包裹的语义。 类似meta组件包裹title和description，这边用来包裹title和内容。
Bundle ReportChanges will increase total bundle size by 4.13kB (0.12%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
| root: '根元素', | ||
| mask: '遮罩层元素', | ||
| content: 'Drawer 容器元素', | ||
| section: 'Drawer 容器元素', |
2 participants
🤔 This is a ...
📝 Change Log