Skip to content

Comments

chore: [v6] rm legacy Icon component#52241

Merged
afc163 merged 1 commit intonextfrom
v6-icon-rm-update
Jan 6, 2025
Merged

chore: [v6] rm legacy Icon component#52241
afc163 merged 1 commit intonextfrom
v6-icon-rm-update

Conversation

@li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Jan 4, 2025

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

这个组件在 V5 时期就已经被废弃了:

image

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English chore: [v6] rm legacy Icon component
🇨🇳 Chinese chore: [v6] rm legacy Icon component

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025

👁 Visual Regression Report for PR #52241 Failed ❌

🎯 Target branch: next (8e8f4e7)
📖 View Full Report ↗︎

Expected (Branch next) Actual (Current PR) Diff
auto-complete-uncertain-category.compact.png auto-complete-uncertain-category.compact.png auto-complete-uncertain-category.compact.png auto-complete-uncertain-category.compact.png
auto-complete-uncertain-category.compact.png auto-complete-uncertain-category.compact.png auto-complete-uncertain-category.compact.css-var.png auto-complete-uncertain-category.compact.css-var.png
avatar-dynamic.compact.png avatar-dynamic.compact.png avatar-dynamic.compact.png avatar-dynamic.compact.png
avatar-dynamic.compact.png avatar-dynamic.compact.png avatar-dynamic.compact.css-var.png avatar-dynamic.compact.css-var.png
badge-change.compact.png badge-change.compact.png badge-change.compact.png badge-change.compact.png
badge-change.compact.png badge-change.compact.png badge-change.compact.css-var.png badge-change.compact.css-var.png
button-color-variant.compact.png button-color-variant.compact.png button-color-variant.compact.png button-color-variant.compact.png
button-color-variant.compact.png button-color-variant.compact.png button-color-variant.compact.css-var.png button-color-variant.compact.css-var.png

Warning

There are more diffs not shown in the table. Please check the Full Report for details.


Important

There are 374 diffs found in this PR: 🔄 314 changed, 🛑 24 removed, 🆕 36 added.
Please check all items:

  • Checked all diffs in the full report
  • Visual diff is acceptable

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025

Preview is ready

@petercat-assistant
Copy link

Walkthrough

This pull request focuses on refactoring by removing the legacy Icon component from the codebase. This involves deleting associated test files and the component's implementation, which were previously used for rendering and testing the Icon component.

Changes

Files Summary
components/icon/tests/snapshots/demo-extend.test.ts.snap, components/icon/tests/snapshots/demo.test.ts.snap Removed snapshot tests related to the legacy Icon component.
components/icon/tests/a11y.test.ts, components/icon/tests/demo-extend.test.ts, components/icon/tests/demo.test.ts, components/icon/tests/image.test.ts, components/icon/tests/index.test.tsx Deleted test files associated with the legacy Icon component.
components/icon/index.tsx Removed the legacy Icon component implementation.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025

size-limit report 📦

Path Size
dist/antd.min.js 441.2 KB
dist/antd-with-locales.min.js 509.41 KB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 4, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52241

commit: 2549d35

@li-jia-nan li-jia-nan mentioned this pull request Jan 4, 2025
@codecov
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b75fd72) to head (2549d35).
Report is 8 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff            @@
##              next    #52241   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       762    -1     
  Lines        13734     13729    -5     
  Branches      3585      3584    -1     
=========================================
- Hits         13734     13729    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cloudflare-workers-and-pages
Copy link

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2549d35
Status: ✅  Deploy successful!
Preview URL: https://877eca23.ant-design.pages.dev
Branch Preview URL: https://v6-icon-rm-update.ant-design.pages.dev

View logs

@afc163 afc163 merged commit 5537e5d into next Jan 6, 2025
47 checks passed
@afc163 afc163 deleted the v6-icon-rm-update branch January 6, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants