Skip to content

Comments

feat: [v6] Retire deprecated api for form#52235

Merged
zombieJ merged 8 commits intonextfrom
v6-kiner-retire-deprecated-api-form
Jan 13, 2025
Merged

feat: [v6] Retire deprecated api for form#52235
zombieJ merged 8 commits intonextfrom
v6-kiner-retire-deprecated-api-form

Conversation

@kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Jan 4, 2025

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English Retire deprecated api for form
🇨🇳 Chinese form 废弃 api 退休

@kiner-tang kiner-tang requested review from crazyair and zombieJ January 4, 2025 03:58
@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Jan 4, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025 •
edited
Loading

Preview is ready

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025 •
edited by kiner-tang
Loading

👁 Visual Regression Report for PR #52235 Failed ❌

🎯 Target branch: next (07c34d9)
📖 View Full Report ↗︎
📊 Summary: 🔄 1 changed

Expected (Branch next) Actual (Current PR) Diff
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png

Important

There are 1 diffs found in this PR: 🔄 1 changed.
Please check all items:

  • Visual diff is acceptable

@petercat-assistant
Copy link

petercat-assistant bot commented Jan 4, 2025

Walkthrough

This pull request focuses on retiring deprecated APIs related to forms in the Ant Design library. The changes involve removing deprecated properties and methods, such as hideRequiredMark, fieldKey, and Form.create, from various components and test files. This update aims to clean up the codebase by eliminating outdated functionalities.

Changes

Files Summary
components/form/Form.tsx, components/form/FormItem/index.tsx, components/form/FormList.tsx Removed deprecated properties hideRequiredMark and fieldKey.
components/form/tests/index.test.tsx Removed tests related to deprecated features like Form.create and hideRequiredMark.
components/form/index.tsx Removed the deprecated Form.create method and related warnings.

petercat-assistant[bot]
petercat-assistant bot reviewed Jan 4, 2025
View reviewed changes
components/form/Form.tsx

return true;
}, [hideRequiredMark, requiredMark, contextForm]);
}, [requiredMark, contextForm]);
Copy link

@petercat-assistant petercat-assistant bot Jan 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that removing hideRequiredMark does not affect any existing functionality that relies on this property. Double-check if any external dependencies or documentation still reference this property.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025 •
edited
Loading

size-limit report 📦

Path Size
dist/antd.min.js 445.29 KB (-26 B 🔽)
dist/antd-with-locales.min.js 513.49 KB (-31 B 🔽)

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 4, 2025 •
edited
Loading

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52235

commit: cd5215d

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 4, 2025 •
edited
Loading

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: cd5215d
Status: ✅  Deploy successful!
Preview URL: https://c1699e72.ant-design.pages.dev
Branch Preview URL: https://v6-kiner-retire-deprecated-a-ctwu.ant-design.pages.dev

View logs

@kiner-tang kiner-tang mentioned this pull request Jan 4, 2025
Closed
@codecov
Copy link

codecov bot commented Jan 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b75fd72) to head (cd5215d).
Report is 55 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #52235   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       760    -3     
  Lines        13734     13695   -39     
  Branches      3585      3580    -5     
=========================================
- Hits         13734     13695   -39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zombieJ
zombieJ reviewed Jan 7, 2025
View reviewed changes
@kiner-tang kiner-tang requested a review from zombieJ January 8, 2025 00:54
@codecov
Copy link

codecov bot commented Jan 8, 2025

Bundle Report

Changes will decrease total bundle size by 2.76kB (-0.08%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.37MB 2.76kB (-0.08%) ⬇️

@zombieJ zombieJ merged commit 50bee02 into next Jan 13, 2025
41 checks passed
@zombieJ zombieJ deleted the v6-kiner-retire-deprecated-api-form branch January 13, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zombieJ zombieJ zombieJ approved these changes

@crazyair crazyair Awaiting requested review from crazyair

+1 more reviewer

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kiner-tang @zombieJ