feat: [v6] Tag support disabled and href by aojunhao123 · Pull Request #52229 · ant-design/ant-design

aojunhao123 · 2025-01-03T15:49:22Z

🤔 This is a ...

🆕 New feature

🔗 Related Issues

close Add for component Tag props Disabled like Button disabled #52158

💡 Background and Solution

Before

After

📝 Change Log

Language	Changelog
🇺🇸 English	feat: Tag support `disabled` and `href`
🇨🇳 Chinese	feat: Tag新增`disabled`和`href`属性

bolt-new-by-stackblitz · 2025-01-03T15:49:24Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2025-01-03T15:49:33Z

👁 Visual Regression Report for PR #52229 Failed ❌

🎯 Target branch: next (5669073)
📖 View Full Report ↗︎
📊 Summary: 🔄 6 changed, 🆕 6 added

Expected (Branch next)	Actual (Current PR)	Diff
input-group.compact.png	input-group.compact.png
input-group.compact.png	input-group.compact.css-var.png
input-group.dark.png	input-group.dark.png
input-group.dark.png	input-group.dark.css-var.png
input-group.default.png	input-group.default.png
input-group.default.png	input-group.default.css-var.png
	tag-disabled.compact.css-var.png	🆕🆕🆕 Added 🆕🆕🆕
	tag-disabled.compact.png	🆕🆕🆕 Added 🆕🆕🆕

Warning

There are more diffs not shown in the table. Please check the Full Report for details.

Important

There are 12 diffs found in this PR: 🔄 6 changed, 🆕 6 added.
Please check all items:

Checked all diffs in the full report
Visual diff is acceptable

github-actions · 2025-01-03T15:49:33Z

petercat-assistant · 2025-01-03T15:49:51Z

Walkthrough

This pull request introduces a new feature that adds disabled support for the Tag component in the Ant Design library. This enhancement allows tags to be disabled, preventing user interactions such as clicks and changes. The update includes modifications to the component's logic, styles, and tests to ensure proper functionality and visual representation when the tag is disabled.

Changes

Files	Summary
components/_util/colors.ts	Refactored `PresetStatusColorTypes` to `PresetStatusColors` for consistency.
components/tag/CheckableTag.tsx	Added `disabled` prop and logic to handle disabled state in `CheckableTag`.
components/tag/tests/index.test.tsx	Added tests to verify behavior of disabled tags and checkable tags.
components/tag/demo/disabled.md	Added documentation for the disabled tag feature.
components/tag/demo/disabled.tsx	Added a demo showcasing the disabled tag functionality.
components/tag/index.en-US.md	Updated API documentation to include `disabled` prop.
components/tag/index.tsx	Implemented `disabled` state handling in `Tag` component.
components/tag/index.zh-CN.md	Updated Chinese API documentation to include `disabled` prop.
components/tag/style/index.ts	Added styles for disabled tags.
components/tag/style/presetCmp.ts	Updated styles to support disabled state.
components/tag/style/statusCmp.ts	Updated styles to support disabled state.

🪧 Tips

For further assistance, please describe your question in the comments and @petercat-assistant to start a conversation with me.

components/tag/CheckableTag.tsx

components/tag/index.tsx

pkg-pr-new · 2025-01-03T15:53:03Z

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52229

commit: f8ce783

codecov · 2025-01-03T15:54:18Z

Bundle Report

Changes will increase total bundle size by 4.12kB (0.12%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.39MB	4.12kB (0.12%) ⬆️

aojunhao123 · 2025-01-03T15:55:07Z

先提一版，可能样式上还得优化一下？等大佬们review😪

components/tag/__tests__/index.test.tsx

components/tag/index.en-US.md

components/tag/index.zh-CN.md

components/tag/index.tsx

components/tag/demo/disabled.tsx

codecov · 2025-01-03T16:22:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cd3c3d8) to head (f8ce783).
Report is 2 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #52229   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          760       760           
  Lines        13673     13681    +8     
  Branches      3570      3576    +6     
=========================================
+ Hits         13673     13681    +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

components/tag/index.en-US.md

This reverts commit b7d9fdb.

components/tag/index.tsx

components/tag/index.zh-CN.md

components/tag/index.tsx

components/tag/style/index.ts

aojunhao123 added 4 commits January 3, 2025 21:41

feat(tag): add disabled

a21641b

docs: improve demo

38b4737

feat: add disabled for checkable tag

044694d

fix: some fix

0ec3dbe

petercat-assistant bot reviewed Jan 3, 2025

View reviewed changes

components/tag/CheckableTag.tsx Show resolved Hide resolved

petercat-assistant bot reviewed Jan 3, 2025

View reviewed changes

components/tag/index.tsx Outdated Show resolved Hide resolved

aojunhao123 changed the title ~~Tag disabled~~ feat(tag): Tag support disabled Jan 3, 2025

li-jia-nan reviewed Jan 3, 2025

View reviewed changes

components/tag/__tests__/index.test.tsx Outdated Show resolved Hide resolved

li-jia-nan reviewed Jan 3, 2025

View reviewed changes

components/tag/index.en-US.md Outdated Show resolved Hide resolved

li-jia-nan reviewed Jan 3, 2025

View reviewed changes

components/tag/index.zh-CN.md Outdated Show resolved Hide resolved

fix: some fix

a47e799

li-jia-nan reviewed Jan 3, 2025

View reviewed changes

components/tag/index.tsx Outdated Show resolved Hide resolved

afc163 reviewed Jan 3, 2025

View reviewed changes

components/tag/demo/disabled.tsx Outdated Show resolved Hide resolved

refactor(tag): streamline click handling for disabled state

d58b7c8

aojunhao123 added 3 commits January 4, 2025 13:57

test: add test case

ba23f0a

test: update snapshot

cfbc8ff

chore: clean code

a42c240

aojunhao123 changed the title ~~feat(tag): Tag support disabled~~ feat(tag): [v6] Tag support disabled Jan 4, 2025

aojunhao123 changed the title ~~feat(tag): [v6] Tag support disabled~~ feat: [v6] Tag support disabled Jan 4, 2025

aojunhao123 requested review from afc163 and li-jia-nan January 4, 2025 06:43

li-jia-nan reviewed Jan 4, 2025

View reviewed changes

components/tag/index.en-US.md Outdated Show resolved Hide resolved

aojunhao123 added 4 commits January 8, 2025 10:01

fix: some fix

b7d9fdb

Revert "fix: some fix"

5d363bb

This reverts commit b7d9fdb.

chore: update doc

7bf4755

chore: update doc

8afd27e

zombieJ reviewed Jan 8, 2025

View reviewed changes

components/tag/index.tsx Outdated Show resolved Hide resolved

aojunhao123 added 6 commits January 9, 2025 15:02

Merge branch 'next' into tag-disabled

d2f1e2a

chore: move inline-style to cssinjs

0dac502

chore: trigger CI build

6a3ccaa

chore: trigger CI build

44c8e0f

Merge branch 'next' into tag-disabled

716b152

Merge branch 'next' into tag-disabled

72ba4ca

zombieJ reviewed Jan 13, 2025

View reviewed changes

components/tag/index.tsx Outdated Show resolved Hide resolved

aojunhao123 added 3 commits January 14, 2025 02:12

feat: tag support href and refactor disabled logic

aa06d1a

Merge branch 'next' into tag-disabled

fc8bed7

test: update snapshot

88e0dbe

aojunhao123 changed the title ~~feat: [v6] Tag support disabled~~ feat: [v6] Tag support disabled and href Jan 14, 2025

zombieJ reviewed Jan 14, 2025

View reviewed changes

components/tag/index.zh-CN.md Outdated Show resolved Hide resolved

zombieJ reviewed Jan 14, 2025

View reviewed changes

components/tag/index.zh-CN.md Outdated Show resolved Hide resolved

zombieJ reviewed Jan 14, 2025

View reviewed changes

components/tag/index.tsx Outdated Show resolved Hide resolved

aojunhao123 added 3 commits January 14, 2025 11:21

Merge branch 'next' into tag-disabled

5785522

docs: add version

69ddd7f

feat: retire deprecated api

70931af

zombieJ reviewed Jan 14, 2025

View reviewed changes

components/tag/style/index.ts Outdated Show resolved Hide resolved

chore: remove component token

b7a656d

zombieJ reviewed Jan 14, 2025

View reviewed changes

components/tag/style/index.ts Outdated Show resolved Hide resolved

chore: update logic

f8ce783

zombieJ approved these changes Jan 14, 2025

View reviewed changes

zombieJ merged commit 6c401b9 into ant-design:next Jan 14, 2025
37 checks passed

aojunhao123 mentioned this pull request Jan 14, 2025

Ant Design v6 tasks #52115

Closed

aojunhao123 deleted the tag-disabled branch January 15, 2025 02:22

Uh oh!

Comments

Conversation

aojunhao123 commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Jan 3, 2025

Uh oh!

github-actions bot commented Jan 3, 2025 • edited by zombieJ Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #52229 Failed ❌

Uh oh!

github-actions bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petercat-assistant bot commented Jan 3, 2025

Walkthrough

Changes

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Uh oh!

aojunhao123 commented Jan 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aojunhao123 commented Jan 3, 2025 •

edited

Loading

github-actions bot commented Jan 3, 2025 •

edited by zombieJ

Loading

github-actions bot commented Jan 3, 2025 •

edited

Loading

pkg-pr-new bot commented Jan 3, 2025 •

edited

Loading

codecov bot commented Jan 3, 2025 •

edited

Loading

codecov bot commented Jan 3, 2025 •

edited

Loading