feat: configProvider support Card.Meta#52214
Conversation
|
|
|
|
👁 Visual Regression Report for PR #52214 Failed ❌
Important There are 1 diffs found in this PR: 🔄
|
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| rootClassName, | ||
| hashId, | ||
| cssVarCls, | ||
| card?.classNames?.root, |
There was a problem hiding this comment.
Ensure that card?.classNames?.root and customClassNames?.root are properly defined before using them in classNames. This could potentially lead to undefined behavior if not handled correctly.
| const rootClassNames = classNames( | ||
| metaPrefixCls, | ||
| className, | ||
| cardMeta?.className, |
There was a problem hiding this comment.
Ensure that cardMeta?.className and cardMeta?.classNames?.root are properly defined before using them in classNames. This could potentially lead to undefined behavior if not handled correctly.
More templates
commit: |
Bundle ReportChanges will increase total bundle size by 7.29kB (0.22%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #52214 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 760 760
Lines 13681 13691 +10
Branches 3576 3576
=========================================
+ Hits 13681 13691 +10 ☔ View full report in Codecov by Sentry. |
|
|
||
| const locales = { | ||
| cn: { | ||
| root: '设置卡片根元素', |
There was a problem hiding this comment.
这里帮忙换一下顺序，从 头 到 cover 到 body 到 action。现在鼠标滑动的时候，它上下来回跑还挺不顺的
| }, | ||
| en: { | ||
| root: 'set `root` of Card.Meta', | ||
| content: 'set `content` of Card.Meta', |
There was a problem hiding this comment.
有点点怪，因为 content 一般在 body 下面，而 body 和 header 是平级关系，现在这个 content 包含了 title 和 description。和其他的逻辑不一样。得找找这种二级容器的替代词。
thinkasany
force-pushed
the
cp-card-next
branch
2 times, most recently
from
58e5ab4 to
c902cc2
Compare
| @@ -0,0 +1,60 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
一起加个 paddingTop or 垂直居中一下~贴顶看起来有点局促
thinkasany
force-pushed
the
cp-card-next
branch
2 times, most recently
from
4e35219 to
74f92f3
Compare
thinkasany
force-pushed
the
cp-card-next
branch
from
74f92f3 to
d0cf3aa
Compare
2 participants
🤔 This is a ...
📝 Change Log