feat: ConfigProvider support classNames and styles for Empty#52208
feat: ConfigProvider support classNames and styles for Empty#52208zombieJ merged 4 commits intoant-design:featurefrom
Conversation
|
|
👁 Visual Regression Report for PR #52208 Failed ❌
Warning There are more diffs not shown in the table. Please check the Full Report for details. Important There are 49 diffs found in this PR: 🔄 49 changed.
|
|
|
WalkthroughThis pull request introduces a new feature to the Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
components/empty/index.tsx
Outdated
|
|
||
| // ============================= Warning ============================== | ||
| if (process.env.NODE_ENV !== 'production') { | ||
| const warning = devUseWarning('Slider'); |
There was a problem hiding this comment.
The warning message uses devUseWarning('Slider'), which seems incorrect for the Empty component. It should be updated to reflect the correct component name to avoid confusion.
More templates
commit: |
Bundle ReportChanges will increase total bundle size by 1.68kB (0.05%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #52208 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 763 763
Lines 13748 13754 +6
Branches 3592 3595 +3
=========================================
+ Hits 13748 13754 +6 ☔ View full report in Codecov by Sentry. |
components/empty/demo/_semantic.tsx
Outdated
| const locales = { | ||
| cn: { | ||
| root: '根元素', | ||
| icon: '图片元素', |
components/empty/index.tsx
Outdated
| > | ||
| <div className={`${prefixCls}-image`} style={imageStyle}> | ||
| <div | ||
| className={classNames(`${prefixCls}-image`, empty?.classNames?.icon, emptyClassNames?.icon)} |
There was a problem hiding this comment.
这个看起来应该去 next，这样 -image 也能改成 -icon
components/empty/demo/_semantic.tsx
Outdated
| ]} | ||
| > | ||
| <Empty | ||
| image="https://gw.alipayobjects.com/zos/antfincdn/ZHrcdLPrvN/empty.svg" |
components/empty/demo/_semantic.tsx
Outdated
| const locales = { | ||
| cn: { | ||
| root: '根元素', | ||
| icon: '图标元素', |
There was a problem hiding this comment.
诶，等等。我发现我错了。这个是 Empty 不是 Result。默认的的确就是 image 不是 icon 的
2 participants
🤔 This is a ...
📝 Change Log