Skip to content

Comments

feat: [v6] Retire deprecated api for cascader#52203

Merged
zombieJ merged 1 commit intonextfrom
v6-kiner-retire-deprecated-api-cascader
Jan 2, 2025
Merged

feat: [v6] Retire deprecated api for cascader#52203
zombieJ merged 1 commit intonextfrom
v6-kiner-retire-deprecated-api-cascader

Conversation

@kiner-tang
Copy link
Member

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English Retire deprecated api for cascader
🇨🇳 Chinese Cascader 废弃 api 退休

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025

Preview is ready

@petercat-assistant
Copy link

Walkthrough

This pull request removes the deprecated dropdownClassName API from the Cascader component, replacing it with popupClassName. The changes involve updating the component's implementation and removing related test cases.

Changes

Files Summary
components/cascader/tests/index.test.tsx Removed test case for deprecated dropdownClassName.
components/cascader/index.tsx Removed dropdownClassName property and related logic, updated to use popupClassName.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025

👁 Visual Regression Report for PR #52203 Passed ✅

🎯 Target branch: next (a8a7f31)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

@kiner-tang kiner-tang mentioned this pull request Jan 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025

size-limit report 📦

Path Size
dist/antd.min.js 442.37 KB (-8 B 🔽)
dist/antd-with-locales.min.js 510.47 KB (-10 B 🔽)

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 1, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52203

commit: 564598d

@codecov
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a8a7f31) to head (564598d).
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff            @@
##              next    #52203   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       763           
  Lines        13650     13648    -2     
  Branches      3563      3562    -1     
=========================================
- Hits         13650     13648    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cloudflare-workers-and-pages
Copy link

@zombieJ zombieJ merged commit ed76bc7 into next Jan 2, 2025
44 checks passed
@zombieJ zombieJ deleted the v6-kiner-retire-deprecated-api-cascader branch January 2, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants