chore: replace TinyColor with FastColor across the codebase#52157
Merged
afc163 merged 2 commits intoant-design:featurefrom Dec 30, 2024
Merged
chore: replace TinyColor with FastColor across the codebase#52157afc163 merged 2 commits intoant-design:featurefrom
afc163 merged 2 commits intoant-design:featurefrom
Conversation
|
|
Contributor
|
|
Contributor
👁 Visual Regression Report for PR #52157 Failed ❌
Warning There are more diffs not shown in the table. Please check the Full Report for details. Important There are 314 diffs found in this PR: 🔄 278 changed, 🆕 36 added.
|
|
Walkthrough: This pull request replaces the Changes:
|
More templates
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #52157 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 763 763
Lines 13735 13735
Branches 3588 3588
=========================================
Hits 13735 13735 ☔ View full report in Codecov by Sentry. |
aojunhao123
force-pushed
the
replace-fast-color
branch
from
8a1db6a to
0e5713a
Compare
Closed
Member
size-limit report 📦
怎么还大了。 |
afc163
approved these changes
Dec 30, 2024
3 tasks
Contributor
Author
|
啊这，负优化？？ |
Contributor
|
没关系，才600B，把另一个完成后会大幅降低。 |
Wxh16144
reviewed
Jan 17, 2025
Comment on lines
32
to
35
| const dotColor = React.useMemo(() => { | ||
| const _color = new TinyColor(value).toHex8String(); | ||
| const _color = new FastColor(value).toHexString(); | ||
| return _color.endsWith('ff') ? _color.slice(0, -2) : _color; | ||
| }, [value]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log
@ctrl/tinycolorwith@ant-design/fast-colorto reduce bundle size.@ant-design/fast-color替换@ctrl/tinycolor以减小打包体积。