Skip to content

Comments

feat: ConfigProvider support tooltip#51872

Merged
zombieJ merged 12 commits intoant-design:featurefrom
thinkasany-forks:cp-tooltip
Dec 24, 2024
Merged

feat: ConfigProvider support tooltip#51872
zombieJ merged 12 commits intoant-design:featurefrom
thinkasany-forks:cp-tooltip

Conversation

@thinkasany
Copy link
Member

@thinkasany thinkasany commented Dec 3, 2024 •
edited
Loading

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature

🔗 Related Issues

解耦 #51814 ， 先完成 tooltip 再完成 popover 再 popconfirm

💡 Background and Solution

rfc： #51885

✅可以使用
🔒特殊组件使用
⚠️不推荐使用，理论上不再新增
🚫废弃，勿用

API 备注
🚫 overlayStyle 使用 styles: { root } 替代
🚫 overlayInnerStyle 使用 styles: { inner} 替代
🚫 overlayClassName 使用 classnames: { root} 替代

📝 Change Log

Language Changelog
🇺🇸 English feat: ConfigProvider supports tooltip
🇨🇳 Chinese feat: ConfigProvider 支持 tooltip 配置

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Dec 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited by zombieJ
Loading

👁 Visual Regression Report for PR #51872 Failed ❌

🎯 Target branch: feature (d810450)
📖 View Full Report ↗︎

Expected (Branch feature) Actual (Current PR) Diff
button-color-variant.dark.png button-color-variant.dark.png button-color-variant.dark.css-var.png button-color-variant.dark.css-var.png
button-debug-color-variant.compact.png button-debug-color-variant.compact.png button-debug-color-variant.compact.css-var.png button-debug-color-variant.compact.css-var.png
button-debug-color-variant.dark.png button-debug-color-variant.dark.png button-debug-color-variant.dark.css-var.png button-debug-color-variant.dark.css-var.png
button-debug-color-variant.default.png button-debug-color-variant.default.png button-debug-color-variant.default.css-var.png button-debug-color-variant.default.css-var.png
checkbox-custom-line-width.compact.png checkbox-custom-line-width.compact.png checkbox-custom-line-width.compact.css-var.png checkbox-custom-line-width.compact.css-var.png
checkbox-custom-line-width.dark.png checkbox-custom-line-width.dark.png checkbox-custom-line-width.dark.css-var.png checkbox-custom-line-width.dark.css-var.png
checkbox-custom-line-width.default.png checkbox-custom-line-width.default.png checkbox-custom-line-width.default.css-var.png checkbox-custom-line-width.default.css-var.png
checkbox-debug-line.compact.png checkbox-debug-line.compact.png checkbox-debug-line.compact.css-var.png checkbox-debug-line.compact.css-var.png

Warning

There are more diffs not shown in the table. Please check the Full Report for details.

Important

There are 40 diffs found in this PR: 🔄 34 changed, 🆕 6 added.
Please check all items:

  • Checked all diffs in the full report
  • Visual diff is acceptable

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

Preview is ready

@thinkasany thinkasany changed the title Cp tooltip feat: ConfigProvider support tooltip Dec 3, 2024
@socket-security
Copy link

socket-security bot commented Dec 3, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 55.2 kB zombiej

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

@codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 1.67kB (0.05%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.39MB 1.67kB (0.05%) ⬆️

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 3, 2024 •
edited
Loading

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@51872

commit: da6390e

@codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d810450) to head (da6390e).
Report is 1 commits behind head on feature.

Additional details and impacted files 
@@            Coverage Diff            @@
##           feature    #51872   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       763           
  Lines        13713     13713           
  Branches      3578      3578           
=========================================
  Hits         13713     13713

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Dec 3, 2024
Closed
Closed
zombieJ
zombieJ reviewed Dec 3, 2024
View reviewed changes
zombieJ
zombieJ reviewed Dec 3, 2024
View reviewed changes
zombieJ
zombieJ reviewed Dec 3, 2024
View reviewed changes
zombieJ
zombieJ reviewed Dec 23, 2024
View reviewed changes
@thinkasany thinkasany requested a review from zombieJ December 24, 2024 02:47
zombieJ
zombieJ reviewed Dec 24, 2024
View reviewed changes
zombieJ
zombieJ reviewed Dec 24, 2024
View reviewed changes
@zombieJ zombieJ merged commit ce87c61 into ant-design:feature Dec 24, 2024
37 checks passed
This was referenced Dec 24, 2024
Merged
Closed
@zombieJ zombieJ mentioned this pull request Jan 6, 2025
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zombieJ zombieJ zombieJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thinkasany @zombieJ