Skip to content

Commit e8fbc23

Browse files
authored
fix(Table): preserve custom header keydown events (#59078)
1 parent a26f19a commit e8fbc23

2 files changed

Lines changed: 15 additions & 1 deletion

File tree

‎components/table/__tests__/Table.sorter.test.tsx‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -999,6 +999,20 @@ describe('Table.sorter', () => {
999999
expect(onClick).toHaveBeenCalled();
10001000
});
10011001

1002+
it('should trigger onHeaderCell onKeyDown for every key in sort column', () => {
1003+
const onKeyDown = jest.fn();
1004+
const { container } = render(createTable({}, { onHeaderCell: () => ({ onKeyDown }) }));
1005+
const headerCell = container.querySelector('th')!;
1006+
1007+
fireEvent.keyDown(headerCell, { key: 'Escape' });
1008+
expect(onKeyDown).toHaveBeenCalledTimes(1);
1009+
expect(renderedNames(container)).toEqual(['Jack', 'Lucy', 'Tom', 'Jerry']);
1010+
1011+
fireEvent.keyDown(headerCell, { key: 'Enter', keyCode: 13 });
1012+
expect(onKeyDown).toHaveBeenCalledTimes(2);
1013+
expect(renderedNames(container)).toEqual(['Jack', 'Jerry', 'Lucy', 'Tom']);
1014+
});
1015+
10021016
it('could sort data with children', () => {
10031017
const { container } = render(
10041018
createTable(

‎components/table/hooks/useSorter.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,8 @@ const injectSorter = <RecordType extends AnyObject = AnyObject>(
235235
sortOrder: nextSortOrder,
236236
multiplePriority: getMultiplePriority<RecordType>(column),
237237
});
238-
originOKeyDown?.(event);
239238
}
239+
originOKeyDown?.(event);
240240
};
241241

242242
const renderTitle = safeColumnTitle(column.title, {});

0 commit comments

Comments
 (0)