Repository navigation
Commit 23207f0
authored
fix: stop mutating the mask config object passed by the user (#59233)
`normalizeMaskConfig` returned the caller's `mask` object when it was a
plain object, and `ConfirmDialog` and `useMergedMask` then wrote
`closable` onto it. A `mask` object that is not re-created on every
render therefore keeps the first `closable` value, so reusing it on
another Modal or Drawer silently disables closing on mask click. Copy
the object so the fill stays local.1 parent e825c6d commit 23207f0
2 files changed
Lines changed: 25 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
1336 | 1337 | | |
1337 | 1338 | | |
1338 | 1339 | | |
| 1340 | + | |
| 1341 | + | |
| 1342 | + | |
| 1343 | + | |
| 1344 | + | |
| 1345 | + | |
| 1346 | + | |
| 1347 | + | |
| 1348 | + | |
| 1349 | + | |
| 1350 | + | |
| 1351 | + | |
| 1352 | + | |
| 1353 | + | |
| 1354 | + | |
| 1355 | + | |
| 1356 | + | |
| 1357 | + | |
| 1358 | + | |
| 1359 | + | |
| 1360 | + | |
| 1361 | + | |
1339 | 1362 | | |
1340 | 1363 | | |
1341 | 1364 | | |
| |||
0 commit comments