Conversation
prmukherj
approved these changes
Feb 23, 2023
hpohekar
approved these changes
Feb 23, 2023
seanpearsonuk
approved these changes
Feb 23, 2023
Collaborator
seanpearsonuk
left a comment
seanpearsonuk
left a comment
There was a problem hiding this comment.
Looks nice, thanks
mkundu1
added a commit
that referenced
this pull request
Mar 16, 2023
* Determine remoting ip address * Infer remoting ip address * Infer remoting ip address * Infer remoting ip address
mkundu1
added a commit
that referenced
this pull request
Mar 17, 2023
* Infer remoting ip address (#1386) * Determine remoting ip address * Infer remoting ip address * Infer remoting ip address * Infer remoting ip address * Bump version 0.12.5 * Code cleanup * pre-commit fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to resolve connection issues within VPN network by automatically inferring the remoting ip address and setting it to
REMOTING_SERVER_ADDRESSenv. var. before launching Fluent. It loops through the ip addresses returned bygetaddinfoand picks up the one with which a grpc connection can be established.The mechanism can be disabled by setting
pyfluent.INFER_REMOTING_IP = False.