Address field data access error handling#1119
Closed
seanpearsonuk wants to merge 11 commits intomainfrom
Closed
Conversation
hpohekar
approved these changes
Nov 30, 2022
ajain-work
approved these changes
Dec 1, 2022
prmukherj
approved these changes
Dec 1, 2022
This was referenced Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to add a bit of safety around field data calls. Up to now, invalid calls (invalid field name, location name) crash Fluent, so I am checking field_info for the validity of names up front, and cleanly raising exceptions in the client as appropriate. An extra feature is that the raised exception can contain hints for closely matching names, which should help many users - we get a lot of queries about what is the right field name to use.
Outstanding issues: