build-init - lenient, fail-on-error, antsibull-version - #27
Merged
briantist merged 11 commits intoFeb 6, 2022
Conversation
felixfontein
reviewed
Feb 5, 2022
felixfontein
approved these changes
Feb 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three new options to the build-init action (and pass-through options on the shared workflows):
lenientfail-on-errorantsibull-versionResolves: #11
Resolves: #1
Resolves: #26
Note:
--fail-on-error(added in ansible-community/antsibull-build#393) is not released as of this writing.The tests are written in such a way (by accident really) that this won't cause them to fail when using
--fail-on-errorwith a version ofantisbullis used that doesn't support it.I think that's ok; it will be released soon, and we aren't really looking to test antsibull itself, so it's probably better that way... open to alternate takes on that, but it will be more complicated for us to re-work the tests so that if detects this as a "failure", only to have the point basically moot when antsibull 0.41.0 is released.