Updates to the Developer Guidelines - #794
Merged
softwarefactory-project-zuul[bot] merged 8 commits intoMay 16, 2022
Merged
Conversation
Contributor
|
Build succeeded.
|
tremble
force-pushed
the
docs/guidelines-4.0.0
branch
from
April 28, 2022 09:45
d778eee to
02ce387
Compare
Contributor
|
Build succeeded.
|
Contributor
|
Build succeeded.
|
…'s recommended by Amazon.
… from new contributors
tremble
force-pushed
the
docs/guidelines-4.0.0
branch
from
May 2, 2022 10:16
cc90f45 to
9d854ef
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Contributor
|
Build succeeded.
|
alinabuzachis
approved these changes
May 3, 2022
Contributor
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 08s |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ansible-collections#794) Add abort multipart upload and expire obj del markers to s3 lifecycle Depends-On: ansible/ansible-zuul-jobs#1247 SUMMARY Fixes ansible-collections#365 ansible-collections#796 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION I have not run integration tests yet because of ansible-collections#793. I'm unsure about how to name and structure the new arguments. Do I nest them to match the API, or flatten them to match existing arguments? Reviewed-by: Alina Buzachis <None> Reviewed-by: Matthew Davis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ansible-collections#794) Add abort multipart upload and expire obj del markers to s3 lifecycle Depends-On: ansible/ansible-zuul-jobs#1247 SUMMARY Fixes ansible-collections#365 ansible-collections#796 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION I have not run integration tests yet because of ansible-collections#793. I'm unsure about how to name and structure the new arguments. Do I nest them to match the API, or flatten them to match existing arguments? Reviewed-by: Alina Buzachis <None> Reviewed-by: Matthew Davis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ansible-collections#794) Add abort multipart upload and expire obj del markers to s3 lifecycle Depends-On: ansible/ansible-zuul-jobs#1247 SUMMARY Fixes ansible-collections#365 ansible-collections#796 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION I have not run integration tests yet because of ansible-collections#793. I'm unsure about how to name and structure the new arguments. Do I nest them to match the API, or flatten them to match existing arguments? Reviewed-by: Alina Buzachis <None> Reviewed-by: Matthew Davis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: Markus Bergholz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Updates for the Developer Guidelines (originally started as ansible/ansible#77598)
ISSUE TYPE
COMPONENT NAME
docs/docsite/rst/dev_guidelines.rst
ADDITIONAL INFORMATION
Validation run can be found at:
https://github.com/tremble/amazon.aws/runs/6192239999?check_suite_focus=true