[PR #792/3f46a945 backport][stable-3] Various docs fixups - #793
Merged
softwarefactory-project-zuul[bot] merged 1 commit intoApr 26, 2022
Conversation
Various docs fixups SUMMARY Attempting to enable a docs linting workflow (#790) we picked up on a number of issues with the docs formating (mostly related to `foo` vs ``foo``) ISSUE TYPE Bugfix Pull Request COMPONENT NAME docs/docsite/rst/dev_guidelines.rst docs/docsite/rst/guide_aws.rst ec2_group ec2_snapshot ec2_vpc_dhcp_option_info ADDITIONAL INFORMATION For a full list of issues: https://github.com/tremble/amazon.aws/runs/6174097260?check_suite_focus=true Reviewed-by: Felix Fontein <[email protected]> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Jill R <None> (cherry picked from commit 3f46a94)
Merged
ansibullbot
added
bug
Contributor
jillr
approved these changes
Apr 26, 2022
Contributor
softwarefactory-project-zuul
Bot
deleted the
patchback/backports/stable-3/3f46a945eda0d42f48fe4335de60a261e5ee6927/pr-792
branch
April 26, 2022 23:02
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ansible-collections#794) Add abort multipart upload and expire obj del markers to s3 lifecycle Depends-On: ansible/ansible-zuul-jobs#1247 SUMMARY Fixes ansible-collections#365 ansible-collections#796 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION I have not run integration tests yet because of ansible-collections#793. I'm unsure about how to name and structure the new arguments. Do I nest them to match the API, or flatten them to match existing arguments? Reviewed-by: Alina Buzachis <None> Reviewed-by: Matthew Davis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ansible-collections#794) Add abort multipart upload and expire obj del markers to s3 lifecycle Depends-On: ansible/ansible-zuul-jobs#1247 SUMMARY Fixes ansible-collections#365 ansible-collections#796 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION I have not run integration tests yet because of ansible-collections#793. I'm unsure about how to name and structure the new arguments. Do I nest them to match the API, or flatten them to match existing arguments? Reviewed-by: Alina Buzachis <None> Reviewed-by: Matthew Davis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ansible-collections#794) Add abort multipart upload and expire obj del markers to s3 lifecycle Depends-On: ansible/ansible-zuul-jobs#1247 SUMMARY Fixes ansible-collections#365 ansible-collections#796 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION I have not run integration tests yet because of ansible-collections#793. I'm unsure about how to name and structure the new arguments. Do I nest them to match the API, or flatten them to match existing arguments? Reviewed-by: Alina Buzachis <None> Reviewed-by: Matthew Davis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: Markus Bergholz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #792 as merged into main (3f46a94).
SUMMARY
Attempting to enable a docs linting workflow (#790) we picked up on a number of issues with the docs formating (mostly related to `foo` vs ``foo``)
ISSUE TYPE
COMPONENT NAME
docs/docsite/rst/dev_guidelines.rst
docs/docsite/rst/guide_aws.rst
ec2_group
ec2_snapshot
ec2_vpc_dhcp_option_info
ADDITIONAL INFORMATION
For a full list of issues:
https://github.com/tremble/amazon.aws/runs/6174097260?check_suite_focus=true