Skip to content

Integration test dependency cleanup - #784

Merged
softwarefactory-project-zuul[bot] merged 4 commits into
ansible-collections:mainfrom
tremble:integration/cleanup
Apr 29, 2022
Merged

Integration test dependency cleanup#784
softwarefactory-project-zuul[bot] merged 4 commits into
ansible-collections:mainfrom
tremble:integration/cleanup

Conversation

@tremble

@tremble tremble commented Apr 21, 2022

Copy link
Copy Markdown
Contributor
SUMMARY
  • remove dependencies on setup_remote_tmp_dir where it's not used (often just copy & paste from another test)
  • remove setup_ec2 (no main.yml means it's not doing anything)
  • remove prepare_tests (empty main.yml means it's not doing anything)
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

tests/integration/targets

ADDITIONAL INFORMATION

By cleaning up what we have we reduce the chance of people copying things about "because that's what test XYZ did".

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration needs_triage plugins plugin (any type) tests tests labels Apr 21, 2022
@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build failed.

@tremble

tremble commented Apr 21, 2022

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build failed.

@tremble

tremble commented Apr 22, 2022

Copy link
Copy Markdown
Contributor Author

recheck

1 similar comment
@tremble

tremble commented Apr 22, 2022

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build succeeded.

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 22, 2022
@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@tremble

tremble commented Apr 22, 2022

Copy link
Copy Markdown
Contributor Author

regate

@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@tremble

tremble commented Apr 23, 2022

Copy link
Copy Markdown
Contributor Author

regate

@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build succeeded.

@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

tremble added 3 commits April 25, 2022 13:50
Remove dependencies on "setup_remote_dir" where it's not being used.
Move path to /var/tmp (/tmp is often tmpfs and can cause problems)
@tremble
tremble force-pushed the integration/cleanup branch from 7bc3b43 to d2aba62 Compare April 25, 2022 11:50
@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build failed.

@jillr

jillr commented Apr 26, 2022

Copy link
Copy Markdown
Contributor

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build failed.

@jillr

jillr commented Apr 26, 2022

Copy link
Copy Markdown
Contributor

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build failed.

@goneri

goneri commented Apr 28, 2022

Copy link
Copy Markdown
Member

regate

@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@tremble

tremble commented Apr 29, 2022

Copy link
Copy Markdown
Contributor Author

regate

@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul
softwarefactory-project-zuul Bot merged commit c5a761d into ansible-collections:main Apr 29, 2022
@tremble
tremble deleted the integration/cleanup branch September 9, 2022 08:51
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
)

ec2_lc: add volume throughput parameter support

SUMMARY

Adding throughput parameter support to ec2_lc.
Fixes ansible-collections#784.

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

community.aws.ec2_lc
UPDATE:
Integration tests being added in a separate PR: ansible-collections#824

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
)

ec2_lc: add volume throughput parameter support

SUMMARY

Adding throughput parameter support to ec2_lc.
Fixes ansible-collections#784.

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

community.aws.ec2_lc
UPDATE:
Integration tests being added in a separate PR: ansible-collections#824

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
)

ec2_lc: add volume throughput parameter support

SUMMARY

Adding throughput parameter support to ec2_lc.
Fixes ansible-collections#784.

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

community.aws.ec2_lc
UPDATE:
Integration tests being added in a separate PR: ansible-collections#824

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) plugins plugin (any type) tests tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants