Prep 3.2.0 release by alinabuzachis · Pull Request #759 · ansible-collections/amazon.aws

alinabuzachis · 2022-03-30T14:20:40Z

SUMMARY

Run add_docs, generate changelog

ISSUE TYPE

Feature Pull Request

softwarefactory-project-zuul · 2022-03-30T14:40:32Z

Build succeeded.

ansible-galaxy-importer : SUCCESS in 5m 13s
build-ansible-collection : SUCCESS in 3m 48s
ansible-test-sanity-aws-ansible-python38 : SUCCESS in 9m 40s
ansible-test-sanity-aws-ansible-2.9-python38 : SUCCESS in 12m 33s
ansible-test-sanity-aws-ansible-2.11-python38 : SUCCESS in 11m 49s
ansible-test-units-amazon-aws-python38 : SUCCESS in 8m 19s
ansible-ee-tests-latest : FAILURE in 13m 43s (non-voting)
ansible-ee-tests-stable-2.9 : SUCCESS in 11m 47s
ansible-ee-tests-stable-2.11 : SUCCESS in 13m 39s
ansible-ee-tests-stable-2.12 : FAILURE in 13m 03s (non-voting)

tremble

A little concerned that we backported a breaking change, but otherwise LGTM

tremble · 2022-03-31T10:05:02Z

+      breaking_changes:
+      - aws_ssm - on_denied and on_missing now both default to error, for consistency
+        with both aws_secret and the base Lookup class (https://github.com/ansible-collections/amazon.aws/issues/617).


Should we have backported a breaking change?

@tremble I thought we could include this breaking change in 3.2.0. What do you suggest to do? Do we want to revert it and include in 4.0.0 directly?

Uh yes. I think it must be reverted from stable-3. It was mentioned here already #618 (comment)

@markuman Can I do it in this PR or do we need a separate one?

Sorry, missed completely that comment.

If possible I would give it a try.

git reset --hard aeba19a # commit before that merge git cherry-pick 7297e31 c06d77c 42295a7 d9d5d0d # cherry pick what comes after

and push with force? But I've no idea if that's more a punk way and will result in merge conflicts?

Ok, thanks. let me try.

...plus rebuild docs and changelog.
naybe there is also a smoother "rebase" way.....

I rebuilt docs, but I have to hard reset and do it from the beginning. It happened in the past the same thing with the docs. I am re-doing right now. I only used git revert commit_hash

softwarefactory-project-zuul · 2022-03-31T12:55:00Z

Build succeeded.

ansible-galaxy-importer : SUCCESS in 5m 23s
build-ansible-collection : SUCCESS in 5m 27s
ansible-test-sanity-aws-ansible-python38 : SUCCESS in 9m 51s
ansible-test-sanity-aws-ansible-2.9-python38 : SUCCESS in 12m 51s
ansible-test-sanity-aws-ansible-2.11-python38 : SUCCESS in 12m 26s
ansible-test-units-amazon-aws-python38 : SUCCESS in 9m 02s
ansible-test-splitter : SUCCESS in 3m 52s
integration-amazon.aws-1 : SKIPPED
integration-amazon.aws-2 : SKIPPED
integration-amazon.aws-3 : SKIPPED
integration-amazon.aws-4 : SKIPPED
integration-amazon.aws-5 : SKIPPED
integration-amazon.aws-6 : SKIPPED
integration-amazon.aws-7 : SKIPPED
integration-amazon.aws-8 : SKIPPED
integration-amazon.aws-9 : SKIPPED
integration-amazon.aws-10 : SKIPPED
integration-amazon.aws-11 : SKIPPED
integration-amazon.aws-12 : SKIPPED
integration-amazon.aws-13 : SKIPPED
integration-community.aws-1 : SUCCESS in 43m 48s
integration-community.aws-2 : SKIPPED
integration-community.aws-3 : SKIPPED
integration-community.aws-4 : SKIPPED
integration-community.aws-5 : SKIPPED
integration-community.aws-6 : SKIPPED
integration-community.aws-7 : SKIPPED
integration-community.aws-8 : SKIPPED
integration-community.aws-9 : SKIPPED
integration-community.aws-10 : SKIPPED
integration-community.aws-11 : SKIPPED
integration-community.aws-12 : SKIPPED
integration-community.aws-13 : SKIPPED
ansible-ee-tests-latest : FAILURE in 13m 08s (non-voting)
ansible-ee-tests-stable-2.9 : SUCCESS in 12m 52s
ansible-ee-tests-stable-2.11 : SUCCESS in 11m 36s
ansible-ee-tests-stable-2.12 : FAILURE in 12m 21s (non-voting)

jillr

The changes to plugins/lookup/aws_ssm.py and tests/unit/plugins/lookup/test_aws_ssm.py don't seem to have been successfully reverted (we shouldn't have python changes in a prep PR - I might just be misunderstanding what's happening in #764 though).

alinabuzachis · 2022-03-31T17:10:42Z

The changes to plugins/lookup/aws_ssm.py and tests/unit/plugins/lookup/test_aws_ssm.py don't seem to have been successfully reverted (we shouldn't have python changes in a prep PR - I might just be misunderstanding what's happening in #764 though).

@jillr Do we want to revert the changes in this PR or should I re-open #764 and merge first that one and then rebase this one? I am reverting the change in this prep PR at the moment.

alinabuzachis · 2022-03-31T18:18:49Z

I re-opened this one and will do the revert directly here #764 instead of having it in the same prep PR.

jillr · 2022-04-01T00:28:16Z

Yep, let's sort out the overall status of the stable-3 branch first and then rebase this PR for docs and changelog only

Run add_docs, generate changelog Signed-off-by: Alina Buzachis <[email protected]>

softwarefactory-project-zuul · 2022-04-05T14:11:06Z

Build succeeded.

ansible-galaxy-importer : SUCCESS in 5m 34s
build-ansible-collection : SUCCESS in 4m 27s
ansible-test-sanity-aws-ansible-python38 : SUCCESS in 12m 57s
ansible-test-sanity-aws-ansible-2.9-python38 : SUCCESS in 21m 14s
ansible-test-sanity-aws-ansible-2.11-python38 : SUCCESS in 14m 32s
ansible-test-units-amazon-aws-python38 : SUCCESS in 12m 28s
ansible-ee-tests-latest : FAILURE in 17m 05s (non-voting)
ansible-ee-tests-stable-2.9 : SUCCESS in 17m 19s
ansible-ee-tests-stable-2.11 : SUCCESS in 11m 34s
ansible-ee-tests-stable-2.12 : FAILURE in 15m 11s (non-voting)

resolved

alinabuzachis · 2022-04-06T07:44:16Z

regate

softwarefactory-project-zuul · 2022-04-06T08:07:30Z

Build succeeded (gate pipeline).

ansible-galaxy-importer : SUCCESS in 5m 11s
build-ansible-collection : SUCCESS in 3m 37s
ansible-test-sanity-aws-ansible-python38 : SUCCESS in 12m 37s
ansible-test-sanity-aws-ansible-2.9-python38 : SUCCESS in 12m 10s
ansible-test-sanity-aws-ansible-2.11-python38 : SUCCESS in 9m 28s
ansible-test-units-amazon-aws-python38 : SUCCESS in 7m 03s
ansible-ee-tests-latest : FAILURE in 15m 57s (non-voting)
ansible-ee-tests-stable-2.9 : SUCCESS in 15m 41s
ansible-ee-tests-stable-2.11 : SUCCESS in 17m 44s
ansible-ee-tests-stable-2.12 : FAILURE in 16m 51s (non-voting)

…_password ec2_win_password - migrate to boto3 SUMMARY Migrate ec2_win_password to boto3 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_win_password ADDITIONAL INFORMATION While there are no tests for this module, there's only a single boto call to update boto2 documentation of call: http://boto.cloudhackers.com/en/latest/ref/ec2.html#boto.ec2.connection.EC2Connection.get_password_data boto3 documentation of call: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2.html#EC2.Client.get_password_data Reviewed-by: Rick Mendes <None> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None>

alinabuzachis requested review from jillr, markuman and tremble March 30, 2022 14:21

ansibullbot added community_review docs feature This issue/PR relates to a feature request needs_triage labels Mar 30, 2022

markuman approved these changes Mar 30, 2022

View reviewed changes

marknet15 approved these changes Mar 31, 2022

View reviewed changes

tremble reviewed Mar 31, 2022

View reviewed changes

ansibullbot added lookup lookup plugin plugins plugin (any type) tests tests labels Mar 31, 2022

alinabuzachis force-pushed the prep_3_2_0 branch from 0755620 to 4edd684 Compare March 31, 2022 12:03

alinabuzachis requested review from markuman and tremble March 31, 2022 12:05

alinabuzachis mentioned this pull request Mar 31, 2022

Revert "Fix on_denied and on_missing bugs (#618) (#747)" #764

Merged

markuman approved these changes Mar 31, 2022

View reviewed changes

jillr previously requested changes Mar 31, 2022

View reviewed changes

ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Mar 31, 2022

markuman mentioned this pull request Apr 2, 2022

Prep 3.2.0 Release ansible-collections/community.aws#1045

Closed

Prep 3.2.0 release

81367c3

Run add_docs, generate changelog Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis force-pushed the prep_3_2_0 branch from 4edd684 to 81367c3 Compare April 5, 2022 13:36

alinabuzachis requested a review from jillr April 5, 2022 13:37

ansibullbot added community_review and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 5, 2022

markuman approved these changes Apr 5, 2022

View reviewed changes

ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Apr 5, 2022

tremble approved these changes Apr 5, 2022

View reviewed changes

alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Apr 5, 2022

goneri removed the needs_triage label Apr 5, 2022

ansibullbot added community_review and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 6, 2022

softwarefactory-project-zuul Bot merged commit a27a3fa into ansible-collections:stable-3 Apr 6, 2022

Uh oh!

Conversation

alinabuzachis commented Mar 30, 2022

SUMMARY

ISSUE TYPE

Uh oh!

softwarefactory-project-zuul Bot commented Mar 30, 2022

Uh oh!

tremble left a comment

Choose a reason for hiding this comment

Uh oh!

tremble Mar 31, 2022

Choose a reason for hiding this comment

Uh oh!

alinabuzachis Mar 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markuman Mar 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alinabuzachis Mar 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alinabuzachis Mar 31, 2022

Choose a reason for hiding this comment

Uh oh!

markuman Mar 31, 2022

Choose a reason for hiding this comment

Uh oh!

alinabuzachis Mar 31, 2022

Choose a reason for hiding this comment

Uh oh!

markuman Mar 31, 2022

Choose a reason for hiding this comment

Uh oh!

alinabuzachis Mar 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

softwarefactory-project-zuul Bot commented Mar 31, 2022

Uh oh!

jillr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alinabuzachis commented Mar 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alinabuzachis commented Mar 31, 2022

Uh oh!

jillr commented Apr 1, 2022

Uh oh!

softwarefactory-project-zuul Bot commented Apr 5, 2022

Uh oh!

alinabuzachis commented Apr 6, 2022

Uh oh!

softwarefactory-project-zuul Bot commented Apr 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

alinabuzachis Mar 31, 2022 •

edited

Loading

markuman Mar 31, 2022 •

edited

Loading

alinabuzachis Mar 31, 2022 •

edited

Loading

alinabuzachis Mar 31, 2022 •

edited

Loading

jillr left a comment •

edited

Loading

alinabuzachis commented Mar 31, 2022 •

edited

Loading