Fix on_denied and on_missing bugs - #618
Conversation
jsf9k
changed the title
|
Build failed.
|
|
@jsf9k thanks for taking the time to submit this pull request. |
|
recheck |
|
Build failed.
|
|
The Zuul build failures appear unrelated to the changes I made. |
|
recheck |
|
Build failed.
|
|
@jsf9k Thank your for taking time to work on this. I was just wondering if the mismatch is only here https://github.com/ansible-collections/amazon.aws/pull/618/files#diff-eee5beb719b6b892c1ebd6a98f7120ad8ab12ccbafaa9b6604938f08da88b7a2L177 and |
|
recheck |
|
Build failed.
|
I'm fine with that @alinabuzachis. Just give me the word and I can do a rebase to this PR to make those changes instead. Or I'll wait for direction from @tremble or @jillr. |
ansibullbot
added
bug
|
recheck |
@alinabuzachis - If what you stated is true, we would still need to modify the documentation here. The statement there pretty clearly indicates that the default for I agree 100% that the behavior of this lookup plugin and that of |
|
aws_secret and the base Lookup class both default to error, so it feels like the best thing to do is keep the behaviour generally consistent between lookup plugins that implement these options. It is breaking, but in a bugfix way, so as long as we include a changelog fragment with the right category and don't backport it to 3.x I think setting it to error is ok. |
|
Build failed.
|
|
@alinabuzachis well the CI running as expected. Github is again facing some problems (https://www.githubstatus.com/), this may explain why it was a bit slow. |
Thanks! |
|
recheck |
1 similar comment
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
alinabuzachis
added
mergeit
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #747 🤖 @patchback |
Fix on_denied and on_missing bugs SUMMARY This pull request: Changes the default value of on_denied to be error, so that it agrees with what is stated in the documentation. Changes the default value of on_missing to be error, and updates the documentation to explain this. Fixes #617. ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ssm lookup Reviewed-by: Alina Buzachis <None> Reviewed-by: Shane Frasier <[email protected]> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit e85e420)
[PR #618/e85e4209 backport][stable-3] Fix on_denied and on_missing bugs This is a backport of PR #618 as merged into main (e85e420). SUMMARY This pull request: Changes the default value of on_denied to be error, so that it agrees with what is stated in the documentation. Changes the default value of on_missing to be error, and updates the documentation to explain this. Fixes #617. ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ssm lookup
Revert "Fix on_denied and on_missing bugs (#618) (#747)" SUMMARY This reverts commit 83a9db6 because it introduces a breaking change that does not need to be included in the current release. ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Jill R <None>
7 participants
SUMMARY
This pull request:
on_deniedto beerror, so that it agrees with what is stated in the documentation.on_missingto beerror, and updates the documentation to explain this.Fixes #617.
ISSUE TYPE
COMPONENT NAME
aws_ssm lookup