Skip to content

ec2_vol: backport to stable-1.5 to fix modify_volume size option bug - #479

Merged
ansible-zuul[bot] merged 1 commit into
ansible-collections:stable-1.5from
mandar242:stable-1.5-backport-371
Sep 9, 2021
Merged

ec2_vol: backport to stable-1.5 to fix modify_volume size option bug#479
ansible-zuul[bot] merged 1 commit into
ansible-collections:stable-1.5from
mandar242:stable-1.5-backport-371

Conversation

@mandar242

@mandar242 mandar242 commented Aug 27, 2021

Copy link
Copy Markdown
Contributor
SUMMARY

Back port to stable-1.5 to fix a bug in modify_volume, 'size' option.

Fixes #471.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_vol

ADDITIONAL INFORMATION
Required fix was done but was not applied in 1.5.0 release.
For more details, please visit #471.

Backports: #371
Depends-On: #491

@mandar242
mandar242 requested a review from jillr August 27, 2021 19:29
@ansibullbot

Copy link
Copy Markdown

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Aug 27, 2021
@alinabuzachis

Copy link
Copy Markdown
Collaborator

recheck

2 similar comments
@tremble

tremble commented Sep 2, 2021

Copy link
Copy Markdown
Contributor

recheck

@tremble

tremble commented Sep 2, 2021

Copy link
Copy Markdown
Contributor

recheck

@jillr jillr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual backport LGTM, the CI failure should be unrelated (I'm looking into it)

@jillr

jillr commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

recheck

@alinabuzachis alinabuzachis linked an issue Sep 6, 2021 that may be closed by this pull request
1 task
@tremble

tremble commented Sep 6, 2021

Copy link
Copy Markdown
Contributor

recheck

3 similar comments
@tremble

tremble commented Sep 7, 2021

Copy link
Copy Markdown
Contributor

recheck

@alinabuzachis

Copy link
Copy Markdown
Collaborator

recheck

@alinabuzachis

Copy link
Copy Markdown
Collaborator

recheck

@tremble tremble added the gate label Sep 9, 2021

@ansible-zuul ansible-zuul Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul
ansible-zuul Bot merged commit fa5d41a into ansible-collections:stable-1.5 Sep 9, 2021
@mandar242
mandar242 deleted the stable-1.5-backport-371 branch October 15, 2021 08:36
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…#479)

Add autoscaling_complete_lifecycle_action module

SUMMARY
I am adding a new Ansible AWS Module which provides the ability to complete a lifecycle action for an AWS Auto Scaling Group. It basically implements the CompleteLifecycleAction AWS API.
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
aws_asg_complete_lifecycle_action.py

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…#479)

Add autoscaling_complete_lifecycle_action module

SUMMARY
I am adding a new Ansible AWS Module which provides the ability to complete a lifecycle action for an AWS Auto Scaling Group. It basically implements the CompleteLifecycleAction AWS API.
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
aws_asg_complete_lifecycle_action.py

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…#479)

Add autoscaling_complete_lifecycle_action module

SUMMARY
I am adding a new Ansible AWS Module which provides the ability to complete a lifecycle action for an AWS Auto Scaling Group. It basically implements the CompleteLifecycleAction AWS API.
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
aws_asg_complete_lifecycle_action.py

Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue/PR relates to a bug community_review integration tests/integration module module plugins plugin (any type) tests tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ec2_vol module errors out when using modify_volume option about 'size'

7 participants