Skip to content

Fixup / ignore new pylint 2.9.3 issues - #460

Merged
ansible-zuul[bot] merged 5 commits into
ansible-collections:mainfrom
tremble:pylint/2.9.3
Aug 12, 2021
Merged

Fixup / ignore new pylint 2.9.3 issues#460
ansible-zuul[bot] merged 5 commits into
ansible-collections:mainfrom
tremble:pylint/2.9.3

Conversation

@tremble

@tremble tremble commented Aug 12, 2021

Copy link
Copy Markdown
Contributor
SUMMARY

The devel containers have been updated to include a new version of pylint ( ansible-collections/overview#45 (comment) )

fixup arguments-renamed
fixup "raise None"
ignore pylint:use-a-generator (Should be an easy fix but not worth blocking gating)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/ec2_instance.py
tests/sanity/ignore-2.12.txt
tests/unit/mock/loader.py
tests/unit/module_utils/test_elbv2.py
tests/unit/module_utils/test_s3.py

ADDITIONAL INFORMATION

@ansibullbot

Copy link
Copy Markdown

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage plugins plugin (any type) tests tests labels Aug 12, 2021
@tremble

tremble commented Aug 12, 2021

Copy link
Copy Markdown
Contributor Author

recheck

@tremble

tremble commented Aug 12, 2021

Copy link
Copy Markdown
Contributor Author

(yet another ec2_vol flake)

@ansible-zuul ansible-zuul Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tremble

tremble commented Aug 12, 2021

Copy link
Copy Markdown
Contributor Author

gate failure was a known flake - should be fixed by #455 and ansible-collections/community.aws#681

@tremble

tremble commented Aug 12, 2021

Copy link
Copy Markdown
Contributor Author

recheck

@ansible-zuul ansible-zuul Bot removed the gate label Aug 12, 2021
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4da568a
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4da568a
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4da568a
alinabuzachis pushed a commit that referenced this pull request Aug 25, 2021
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4da568a
alinabuzachis pushed a commit that referenced this pull request Aug 25, 2021
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4da568a
alinabuzachis pushed a commit that referenced this pull request Aug 25, 2021
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4da568a
alinabuzachis pushed a commit that referenced this pull request Aug 26, 2021
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4da568a
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 26, 2021
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4da568a
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 26, 2021
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4da568a
tremble added a commit to tremble/amazon.aws that referenced this pull request Sep 6, 2021
…s#460)

The devel containers have been updated to include a new version of pylint ( ansible-collections/overview#45 (comment) )
fixup arguments-renamed
ignore pylint:use-a-generator (Should be an easy fix but not worth blocking gating)
ansible-zuul Bot pushed a commit that referenced this pull request Sep 8, 2021
Backport - Fixup / ignore new pylint 2.9.3 issues

SUMMARY
The containers have been updated to include a new version of pylint ( ansible-collections/overview#45 )
fixup arguments-renamed
ignore pylint:use-a-generator (an easy fix but not worth blocking gating)
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
tests/unit/mock/loader.py
tests/unit/module_utils/test_elbv2.py
ADDITIONAL INFORMATION
Backport of #460
Depends-On: ansible/ansible-zuul-jobs#1097

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
@tremble
tremble deleted the pylint/2.9.3 branch November 26, 2021 12:42
tremble added a commit to tremble/amazon.aws that referenced this pull request Apr 20, 2022
ec2_key : Fix tests

SUMMARY
The Zuul nodes don't have OpenSSL installed on them, this breaks the generation of the fingerprints
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_key
ADDITIONAL INFORMATION
https://dashboard.zuul.ansible.com/t/ansible/build/d79dcec2e3024558800bba5fd6917505/log/job-output.txt
"stderr": "/bin/sh: line 1: openssl: command not found"

Depends-on: ansible-collections#460

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
(cherry picked from commit 963a829)
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage plugins plugin (any type) tests tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants